Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes in resources and tests #1282

Merged
merged 6 commits into from
Jun 19, 2024

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Jun 18, 2024

Contents

Bugfixes

  • Fixes vcd_nsxt_ipsec_vpn_tunnel update operation: The update of Security Profile Customization was done after IPSec settings, which is not correct. If there's no Security Profile Customization and we put securityType=CUSTOM in IPSec settings, it will naturally fail. If we reverse the operations (this fix), it will work, as the customization is created first, then we say that securityType=CUSTOM.

  • Bumps SDK to fix the issues stated in Miscellaneous fixes in methods and tests go-vcloud-director#688

Test fixes

  • Fixes OIDC test: There's a fixed bug that makes RedirectUri to be always lowercase in VCD. This change was made agnostic of the API version, so we can't use that do make the test checkers conditional. The fix simply makes a regular expression case insensitive.

How to test

Run the following tests in VCD 10.6+. They should fail without this patch, and pass with all these changes:

TestAccVcdOrgOidc
TestAccVcdNsxtIpSecVpnTunnelCustomProfile
TestAccVcdNsxVdcGroupCompleteMigration

abarreiro added 4 commits June 18, 2024 10:10
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro changed the title WIP: Fix tests WIP: Fixes in resources and tests Jun 18, 2024
@adambarreiro adambarreiro changed the title WIP: Fixes in resources and tests WIP: Miscellaneous fixes in resources and tests Jun 18, 2024
@adambarreiro adambarreiro self-assigned this Jun 18, 2024
@adambarreiro adambarreiro marked this pull request as ready for review June 18, 2024 15:28
@adambarreiro adambarreiro changed the title WIP: Miscellaneous fixes in resources and tests Miscellaneous fixes in resources and tests Jun 18, 2024
abarreiro added 2 commits June 19, 2024 09:44
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro merged commit bc9faab into vmware:main Jun 19, 2024
2 checks passed
@adambarreiro adambarreiro deleted the fixes branch June 19, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants