Miscellaneous fixes in resources and tests #1282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents
Bugfixes
Fixes
vcd_nsxt_ipsec_vpn_tunnel
update operation: The update of Security Profile Customization was done after IPSec settings, which is not correct. If there's no Security Profile Customization and we putsecurityType=CUSTOM
in IPSec settings, it will naturally fail. If we reverse the operations (this fix), it will work, as the customization is created first, then we say thatsecurityType=CUSTOM
.Bumps SDK to fix the issues stated in Miscellaneous fixes in methods and tests go-vcloud-director#688
Test fixes
RedirectUri
to be always lowercase in VCD. This change was made agnostic of the API version, so we can't use that do make the test checkers conditional. The fix simply makes a regular expression case insensitive.How to test
Run the following tests in VCD 10.6+. They should fail without this patch, and pass with all these changes: