Add route advertisement support to vcd_network_routed_v2 #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didainius
force-pushed
the
orgvdc-routed-ra
branch
from
d401fe6 to
5cd5a98
Compare
…ce and data source Signed-off-by: Dainius Serplis <[email protected]>
Didainius
force-pushed
the
orgvdc-routed-ra
branch
from
5cd5a98 to
34779e0
Compare
Didainius
requested review from
lvirbalas,
adambarreiro and
dataclouder
as code owners
lvirbalas
approved these changes
Feb 2, 2024
|
@Didainius I tested it. It works :) |
Signed-off-by: Dainius Serplis <[email protected]>
adambarreiro
reviewed
Mar 6, 2024
adambarreiro
approved these changes
Mar 7, 2024
dataclouder
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds route advertisement support to
vcd_network_routed_v2via fieldroute_advertisement_enabledwhich is requested in #1105.Documentation is updated with details, but this feature can be enabled when IP Spaces are being used in the configuration of parent provider gateway [vcd_external_network_v2] (uses IP Space uplink).
Closes #1105
Tests passed with tags
networkandnsxton 10.5.1. Also all network tests starting withTestAccVcdNetworkRoutedV2worked on 10.4.0.