Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network pool resource #1115

Merged
merged 64 commits into from
Nov 14, 2023
Merged

Network pool resource #1115

merged 64 commits into from
Nov 14, 2023

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Sep 6, 2023 •
edited by adezxc
Loading

Add network pool resource and improve network pool data source

  • Add network pool resource
    • Type GENEVE
    • Type Portgroup-backed
    • Type VLAN
    • Read
    • Create
    • Update
    • Delete
    • Import
  • Improve network pool data source
  • Add retrieval of needed entities through vcd_resource_list
    • vCenter
    • NSX-T manager
    • distributed switches
    • transport zones
    • port groups
  • Add network pool creation, update, and import test
  • Add network pool creation to Provider VDC test
  • Write docs
  • Add changelog entries
  • Fix Issue Data source vcd_vcenter fails when name contains spaces #1112

Giuseppe Maxia added 15 commits September 5, 2023 16:45
Fix Issue vmware#1112 space in vCenter name fails data source
f2d494b 
Signed-off-by: Giuseppe Maxia <[email protected]>
WIP adding fields to datasource_vcd_network_pool
a3c367b 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add listing for more resources
db6c0b4 
* vcd_vcenter
* vcd_nxst_manager
* vcd_network_pool
* vcd_nsxt_transport_zone
* vcd_importable_port_group
* vcd_distributed_switch

Signed-off-by: Giuseppe Maxia <[email protected]>
WIP update TestAccVcdDatasourceResourceList
b2026e6 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update govcd
ea04e99 
Signed-off-by: Giuseppe Maxia <[email protected]>
Merge branch 'main' into network-pools
c75398f 
Signed-off-by: Giuseppe Maxia <[email protected]>
Improve TestAccVcdDatasourceResourceList
5ff93e3 
Add ability of checking for any (unnamed) item returned

Signed-off-by: Giuseppe Maxia <[email protected]>
Merge branch 'main' into network-pools
79991d2 
Signed-off-by: Giuseppe Maxia <[email protected]>
Merge branch 'main' into network-pools
6466cbf 
Signed-off-by: Giuseppe Maxia <[email protected]>
Merge branch 'main' into network-pools
28a7fc0 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add resource vcd_network_pool
075045b 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update datasource vcd_network_pool
b834664 
Signed-off-by: Giuseppe Maxia <[email protected]>
Implement vcd_network_pool create for all types
dfac256 
Signed-off-by: Giuseppe Maxia <[email protected]>
Merge branch 'main' into network-pools
be3e15f 
Signed-off-by: Giuseppe Maxia <[email protected]>
Fix staticcheck warning
e01702c 
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder self-assigned this Sep 27, 2023
Giuseppe Maxia added 12 commits September 27, 2023 21:39
Update ProviderVdc test with new network pool
2e699b1 
Signed-off-by: Giuseppe Maxia <[email protected]>
Improve transport zone retrieval
79c884f 
Signed-off-by: Giuseppe Maxia <[email protected]>
Implement network pool Update and Import
1c22935 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add test for vcd_network_pool
e73a271 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update build tags
5b49596 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update network pool data source docs
cbda714 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update data source vcd_resource_list docs
a14c16c 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add docs for resource vcd_network_pool
4b782c0 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add skip message to TestAccVcdResourceNetworkPool
2636640 
Signed-off-by: Giuseppe Maxia <[email protected]>
Fix HCL formatting in docs
23c45bd 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add changelog items
7ecc831 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update vcd.erb
3b7f9cc 
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder marked this pull request as ready for review September 29, 2023 08:59
Giuseppe Maxia added 6 commits October 23, 2023 17:30
Add backing_components_use_constraint field
673d85a 
Add ability of using multiple port groups

Signed-off-by: Giuseppe Maxia <[email protected]>
Merge branch 'main' into network-pools
acf1fbd 
Signed-off-by: Giuseppe Maxia <[email protected]>
Merge branch 'main' into network-pools
318998c 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add more schema checking
c9c7d2d 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update docs
a455181 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add ForceNew attribute to backing elements
2244ba7 
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder marked this pull request as ready for review October 24, 2023 10:56
Giuseppe Maxia added 2 commits October 26, 2023 20:29
Update govcd
e1b7a92 
Signed-off-by: Giuseppe Maxia <[email protected]>
Merge branch 'main' into network-pools
82e0870 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add check on expected provider type
9856019 
Signed-off-by: Giuseppe Maxia <[email protected]>
Didainius
Didainius approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have experimented configuring with ways that are possible in UI and gone over the examples in documentation.

Tests passed on multiple versions 10.4.1<->10.5.0

vcd/resource_vcd_network_pool.go Outdated Show resolved Hide resolved
website/docs/r/network_pool.html.markdown Outdated Show resolved Hide resolved
website/docs/r/network_pool.html.markdown Show resolved Hide resolved
website/docs/r/network_pool.html.markdown Show resolved Hide resolved
vcd/datasource_vcd_resource_list.go Outdated Show resolved Hide resolved
vcd/resource_vcd_network_pool_test.go Outdated Show resolved Hide resolved
website/docs/r/network_pool.html.markdown Outdated Show resolved Hide resolved
adambarreiro
adambarreiro approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests passed on the latest VCD version.

Giuseppe Maxia added 5 commits October 31, 2023 12:05
lvirbalas
lvirbalas requested changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the new approach for the backing selection! Please find some suggestions inline (mainly polishing the idea further).

website/docs/r/network_pool.html.markdown Outdated Show resolved Hide resolved
website/docs/r/network_pool.html.markdown Outdated Show resolved Hide resolved
website/vcd.erb Outdated Show resolved Hide resolved
website/docs/r/network_pool.html.markdown Outdated Show resolved Hide resolved
website/docs/r/network_pool.html.markdown Outdated Show resolved Hide resolved
website/docs/r/network_pool.html.markdown Outdated Show resolved Hide resolved
Giuseppe Maxia added 5 commits November 10, 2023 05:38
Update docs
f657a02 
Signed-off-by: Giuseppe Maxia <[email protected]>
Change backing_components_use_constraint to backing_selection_constraint
a2fcdb9 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update docs
b21a64b 
Signed-off-by: Giuseppe Maxia <[email protected]>
Remove 'backing' component from test
b6094fa 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update docs
c102431 
Signed-off-by: Giuseppe Maxia <[email protected]>
lvirbalas
lvirbalas approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great now! Thank you for all the optimizations!

adezxc
adezxc approved these changes Nov 14, 2023
View reviewed changes
Copy link

@adezxc adezxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test functions, will definitely take notes from that!

Giuseppe Maxia added 2 commits November 14, 2023 16:04
Update govcd dependency
816a994 
Signed-off-by: Giuseppe Maxia <[email protected]>
Merge branch 'main' into network-pools
06b3f97 
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder merged commit a1637f4 into vmware:main Nov 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adezxc adezxc adezxc approved these changes

@Didainius Didainius Didainius approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@adambarreiro adambarreiro adambarreiro approved these changes

Assignees

@dataclouder dataclouder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dataclouder @adambarreiro @lvirbalas @Didainius @adezxc