Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixes (dhcpv6, (vcd_nsxt_edgegateway_dhcpv6, TestAccDataSourceNotFound, BGP Vrf) #1083

Merged
merged 5 commits into from
Jul 18, 2023

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Jul 17, 2023

  • Removed enabled field in test and some sample snippets of website c5d1073
=== RUN   TestAccVcdIpv6Support
    ipv6_test.go:44: Step 1/1 error: Error running pre-apply refresh: exit status 1

        Error: Unsupported argument

          on terraform_plugin_test.tf line 143, in resource "vcd_nsxt_edgegateway_dhcpv6" "test":                                                               143:   enabled = true
        An argument named "enabled" is not expected here.
--- FAIL: TestAccVcdIpv6Support (2.59s)
  • Probably was a corrupt merge 1344ad0
=== RUN   TestAccDataSourceNotFound/vcd_ip_space_uplink
    datasource_not_found_test.go:147: Step 1/1, expected an error with pattern, no match on: Error running pre-apply refresh: exit status 1

        Error: Unsupported argument

          on terraform_plugin_test.tf line 6, in data "vcd_ip_space_uplink" "not-existing":
           6: rde_type_id = "urn:vcloud:type:notexist:notexist:9.9.9"

        An argument named "rde_type_id" is not expected here.
--- FAIL: TestAccDataSourceNotFound (6.73s)
    --- FAIL: TestAccDataSourceNotFound/vcd_ip_space_uplink (0.37s)
  • TestAccVcdNsxtEdgeBgpConfigVrf VCD with API V38.0 requires GracefulRestart even if non was presented. The fix is to read existing GracefulRestart values and submit them when user does not provide this configuration. 1522e7a
=== RUN   TestAccVcdNsxtEdgeBgpConfigVrf
    resource_vcd_nsxt_edgegateway_bgp_configuration_test.go:339: Step 1/5 error: Error running apply: exit status 1
        
        Error: error updating NSX-T Edge Gateway BGP Configuration: error setting NSX-T Edge Gateway BGP Configuration: error in HTTP PUT request: BAD_REQUEST - [ dd125787-82be-4d80-b83a-b478462dbd84 ] Cannot change graceful restart configuration if using a VRF-Lite backed external network.
        
          with vcd_nsxt_edgegateway_bgp_configuration.testing,
          on terraform_plugin_test.tf line 56, in resource "vcd_nsxt_edgegateway_bgp_configuration" "testing":
          56: resource "vcd_nsxt_edgegateway_bgp_configuration" "testing" {
        
--- FAIL: TestAccVcdNsxtEdgeBgpConfigVrf (52.49s)

@Didainius Didainius changed the title Removed 'enabled' from test and docs for vcd_nsxt_edgegateway_dhcpv6 Test fixes Jul 17, 2023
@Didainius Didainius changed the title Test fixes Test fixes (vcd_nsxt_edgegateway_dhcpv6, TestAccDataSourceNotFound/vcd_ip_space_uplink) Jul 18, 2023
@Didainius Didainius marked this pull request as ready for review July 18, 2023 05:09
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

…BgpGracefulRestartConfig'

Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius changed the title Test fixes (vcd_nsxt_edgegateway_dhcpv6, TestAccDataSourceNotFound/vcd_ip_space_uplink) Test fixes (dhcpv6, (vcd_nsxt_edgegateway_dhcpv6, TestAccDataSourceNotFound, BGP Vrf) Jul 18, 2023
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius merged commit 798c34f into vmware:main Jul 18, 2023
@Didainius Didainius deleted the 3.10-fixes branch July 18, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants