Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource vcd_cloned_vapp #1081

Merged
merged 19 commits into from
Jul 14, 2023
Merged

Add resource vcd_cloned_vapp #1081

merged 19 commits into from
Jul 14, 2023

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Jul 12, 2023

Address Issue #741
Add resource vcd_cloned_vapp, which allows creating a vApp from either a vApp template or another vApp.

Testing

The needed vApp template will be uploaded during the test.

go test -tags vapp -run TestAccVcdClonedVApp -v -timeout 0

Giuseppe Maxia added 9 commits July 12, 2023 09:04
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder marked this pull request as ready for review July 13, 2023 03:38
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main ask is to expand documentation explaining more about when one should use this resource.

website/docs/r/cloned_vapp.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cloned_vapp.html.markdown Show resolved Hide resolved
website/docs/r/cloned_vapp.html.markdown Outdated Show resolved Hide resolved
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Giuseppe Maxia added 2 commits July 13, 2023 14:37
website/vcd.erb Show resolved Hide resolved
vcd/resource_vcd_cloned_vapp.go Outdated Show resolved Hide resolved
vcd/resource_vcd_cloned_vapp.go Show resolved Hide resolved
vcd/resource_vcd_cloned_vapp.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vcd/remove_leftovers_test.go Outdated Show resolved Hide resolved
Giuseppe Maxia added 6 commits July 14, 2023 09:55
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder merged commit 87b77ac into vmware:main Jul 14, 2023
@dataclouder dataclouder deleted the vapp-full branch November 20, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants