Fix IPSec VPN Tunnel resource Update #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Jasinski <[email protected]>
adezxc
requested review from
lvirbalas,
Didainius,
adambarreiro and
dataclouder
as code owners
Signed-off-by: Adam Jasinski <[email protected]>
Didainius
approved these changes
Jun 22, 2023
lvirbalas
requested changes
Jun 26, 2023
added 3 commits
June 27, 2023 13:16
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Added :) |
lvirbalas
approved these changes
Jun 27, 2023
dataclouder
approved these changes
Jul 10, 2023
dataclouder
approved these changes
Jul 10, 2023
adambarreiro
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug described in #1069.
The workflow of "update the ipsec vpn profile, but not the security settings" was untested, so it would set to default
every time there was a change in the main schema, but not
security_profile_customization