-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPv6 support improvements #1071
Conversation
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Some suggestions inline.
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm mostly good with this, just a few questions
Signed-off-by: Dainius Serplis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First scan
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
This PR attempts to ensure that IPv6 is well supported in Terraform. There were different cases across our resources - some worked, but didn’t have IPv6 tests, some supported IPv6 but lacked additional configuration options relating to IPv6 and some specific resources were missing.
New resources:
vcd_nsxt_edgegateway_dhcpv6
(Enables DHCPv6 for NSX-T Edge Gateway)New tests added:
vcd_external_network_v2
vcd_nsxt_ip_set
vcd_nsxt_edgegateway
vcd_nsxt_network_dhcp
(DHCPv6 is only supported on vcd_network_routed_v2 with enabled vcd_nsxt_edgegateway_dhcpv6)vcd_nsxt_network_dhcp_binding
(routed network only, improved docs)Modified resources:
vcd_network_routed_v2
secondary network fields (and docs)vcd_network_isolated_v2
secondary network fields (and docs)vcd_nsxt_network_imported
secondary network fields (and docs)vcd_nsxt_alb_virtual_service
adds support for IPv6 Virtual Service IP via fieldipv6_virtual_ip_address
Note. Main testing file is
ipv6_test.go
which touches the integration of all these components using IPv6 configuration