Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 support improvements #1071

Merged
merged 19 commits into from
Jul 17, 2023
Merged

IPv6 support improvements #1071

merged 19 commits into from
Jul 17, 2023

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Jun 20, 2023

This PR attempts to ensure that IPv6 is well supported in Terraform. There were different cases across our resources - some worked, but didn’t have IPv6 tests, some supported IPv6 but lacked additional configuration options relating to IPv6 and some specific resources were missing.

New resources:

  • vcd_nsxt_edgegateway_dhcpv6 (Enables DHCPv6 for NSX-T Edge Gateway)

New tests added:

  • vcd_external_network_v2
  • vcd_nsxt_ip_set
  • vcd_nsxt_edgegateway
  • vcd_nsxt_network_dhcp (DHCPv6 is only supported on vcd_network_routed_v2 with enabled vcd_nsxt_edgegateway_dhcpv6)
  • vcd_nsxt_network_dhcp_binding (routed network only, improved docs)

Modified resources:

  • vcd_network_routed_v2 secondary network fields (and docs)
  • vcd_network_isolated_v2 secondary network fields (and docs)
  • vcd_nsxt_network_imported secondary network fields (and docs)
  • vcd_nsxt_alb_virtual_service adds support for IPv6 Virtual Service IP via field ipv6_virtual_ip_address

Note. Main testing file is ipv6_test.go which touches the integration of all these components using IPv6 configuration

Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius changed the title WIP: Review IPv6 support IPv6 support review Jun 27, 2023
@Didainius Didainius changed the title IPv6 support review IPv6 support improvements Jun 27, 2023
@Didainius Didainius marked this pull request as ready for review June 27, 2023 07:13
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Some suggestions inline.

vcd/datasource_vcd_network_isolated_v2.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_nsxt_edgegateway_dhcpv6.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_nsxt_edgegateway_dhcpv6.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_nsxt_network_imported.go Outdated Show resolved Hide resolved
vcd/resource_vcd_nsxt_edgegateway_dhcpv6.go Outdated Show resolved Hide resolved
vcd/resource_vcd_nsxt_edgegateway_dhcpv6.go Outdated Show resolved Hide resolved
vcd/resource_vcd_nsxt_edgegateway_dhcpv6.go Outdated Show resolved Hide resolved
vcd/resource_vcd_nsxt_edgegateway_dhcpv6.go Outdated Show resolved Hide resolved
website/docs/d/nsxt_edgegateway_dhcpv6.html.markdown Outdated Show resolved Hide resolved
website/docs/r/nsxt_edgegateway_dhcpv6.html.markdown Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Copy link

@adezxc adezxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly good with this, just a few questions

vcd/resource_vcd_nsxt_edgegateway_dhcpv6.go Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <[email protected]>
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First scan

vcd/datasource_vcd_network_isolated_v2.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_network_isolated_v2.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_network_isolated_v2.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_network_routed_v2.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_network_routed_v2.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_nsxt_network_imported.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_nsxt_network_imported.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_nsxt_network_imported.go Outdated Show resolved Hide resolved
website/docs/d/nsxt_edgegateway_dhcpv6.html.markdown Outdated Show resolved Hide resolved
website/docs/d/nsxt_edgegateway_dhcpv6.html.markdown Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius merged commit 3d8bd22 into vmware:main Jul 17, 2023
@Didainius Didainius deleted the ipv6-support branch July 17, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants