Add vcd_ui_plugin resource and data source to programmatically manage UI Plugins #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 23, 2023 17:10
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
adambarreiro
changed the title
added 15 commits
May 23, 2023 17:13
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
terraform-provider-vcd-bot
added
test-running:acc
test-failed:acc
and removed
test-request:acc
test-running:acc
labels
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
adambarreiro
requested review from
lvirbalas,
Didainius,
dataclouder and
adezxc
as code owners
lvirbalas
approved these changes
Jun 7, 2023
added 2 commits
June 7, 2023 09:23
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Didainius
reviewed
Jun 14, 2023
added 4 commits
June 20, 2023 10:46
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Didainius
approved these changes
Jun 20, 2023
dataclouder
reviewed
Jun 21, 2023
examples/container-service-extension-4.0/install/step2/terraform.tfvars.example
Outdated
Show resolved
Hide resolved
examples/container-service-extension-4.0/install/step2/terraform.tfvars.example
Outdated
Show resolved
Hide resolved
Signed-off-by: abarreiro <[email protected]>
dataclouder
reviewed
Jun 21, 2023
added 2 commits
June 21, 2023 16:41
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
adezxc
approved these changes
Jun 28, 2023
Signed-off-by: abarreiro <[email protected]>
dataclouder
approved these changes
Jul 12, 2023
Signed-off-by: abarreiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a new resource and data source vcd_ui_plugin, so service providers can install UI Plugins programmatically.
Despite it can be a bit contradictory at first glance, as Terraform is a pure IaC tool, it makes sense in a scenario where the service provider uses Terraform to automate all VCD infrastructure but her tenant users don't. In this case, a service provider may need to install the UI Plugins using Terraform for their tenants to use them.
This PR additionally updates the CSE guide to install the Kubernetes Container Clusters UI Plugin making use of this new resource.
Depdendencies
Requires vmware/go-vcloud-director#575
Tests
Tested on VCD 10.4.2, 10.4.1, 10.3.3, 10.3.0