Go 1.20 support for testing scripts #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
requested review from
lvirbalas,
adambarreiro,
dataclouder and
adezxc
as code owners
lvirbalas
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Thanks! This PR also reminds me that we saw a parameter deprecation in goreleaser (was it --rm-dist, which will be removed around June?):
https://goreleaser.com/deprecations/
Yes, but this command is not used in any code in the repo, we run it manually usually so that shouldn't cause any unexpected things break. |
adezxc
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.20 removed
-iflag (was deprecated in 1.19) andmake test-binary-preparefails on Go 1.20 now. This PR fixes it.It also uses Go 1.20 in GitHub actions now.
Additionally, it bumps
staticcheckto latest version2023.1.3