Fix IndependentDisk, SubscribedCatalog and NsxtDynamicSecurityGroup flaky tests #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 3, 2023 17:26
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
adezxc
requested review from
lvirbalas,
Didainius,
adambarreiro and
dataclouder
as code owners
Signed-off-by: Adam Jasinski <[email protected]>
adambarreiro
approved these changes
Mar 8, 2023
terraform-provider-vcd-bot
added
test-running:acc
test-failed:acc
and removed
test-request:acc
test-running:acc
labels
dataclouder
reviewed
Mar 8, 2023
Signed-off-by: Adam Jasinski <[email protected]>
dataclouder
reviewed
Mar 8, 2023
Signed-off-by: Adam Jasinski <[email protected]>
terraform-provider-vcd-bot
added
test-running:acc
test-failed:acc
and removed
test-request:acc
test-running:acc
labels
dataclouder
approved these changes
Mar 9, 2023
lvirbalas
reviewed
Mar 9, 2023
adezxc
changed the title
adezxc
changed the title
Signed-off-by: Adam Jasinski <[email protected]>
lvirbalas
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes these flaky tests:
TestAccVcdIndependentDiskBasicwas sometimes failing while updating the independent disk, but it seems that this is VCD's fault. Theupdatesteps were removed, and another version of this test was created,TestAccVcdIndependentDiskBasicWithUpdatesthat is automatically skipped on all the current versions of VCD and will be run in the new one to see if the issue is gone.TestAccVcdNsxtDynamicSecurityGroupVdcGroupCriteriaWithVmswas sometimes failing as it was trying to retrieve the count of member VMs, while the VMs weren't fully created, so the time.Sleep() function length was increased to accomodate for the time when VMs are still being created.TestAccVcdVsphereSubscriberandTestAccVcdSubscribedCatalogwere failing due to a bug in VCD versions prior to v10.4.0, so they are skipped if ran on versions that don't match that requirement.