Skip to content

Remove TSM integration support #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Remove TSM integration support #475

merged 1 commit into from
Dec 13, 2024

Conversation

vivgoyal
Copy link
Contributor

@vivgoyal vivgoyal commented Dec 12, 2024

Summary

Removes TSM integration support.

Type

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe: Removal of a feature

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Additional Information

Signed-off-by: Vivek Goyal [email protected]

@vmwclabot vmwclabot added the dco-required DCO Required label Dec 12, 2024
@github-actions github-actions bot added provider Provider needs-review Needs Review labels Dec 12, 2024
@github-actions github-actions bot added the documentation Documentation label Dec 12, 2024
@vmwclabot vmwclabot removed the dco-required DCO Required label Dec 12, 2024
@tenthirtyam tenthirtyam added the breaking-change Breaking Change label Dec 12, 2024
@tenthirtyam tenthirtyam added this to the .next milestone Dec 12, 2024
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall, there are some references to integrations in the Makefile, .github/workflows/release.yml, and .github/workflows/tests.yml that may need an update.

@github-actions github-actions bot added chore Chore github-actions GitHub Actions labels Dec 12, 2024
@vivgoyal
Copy link
Contributor Author

If I recall, there are some references to integrations in the Makefile, .github/workflows/release.yml, and .github/workflows/tests.yml that may need an update.

fixed

Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could you update the commit signing to our broadcom.com emails (assuming attached to your profile) since our vmware.com addresses are now decommissioned?

@vmwclabot vmwclabot added the dco-required DCO Required label Dec 13, 2024
@vivgoyal
Copy link
Contributor Author

Nit: Could you update the commit signing to our broadcom.com emails (assuming attached to your profile) since our vmware.com addresses are now decommissioned?

Done

@vmwclabot vmwclabot removed the dco-required DCO Required label Dec 13, 2024
@vmware vmware deleted a comment from vmwclabot Dec 13, 2024
@vmware vmware deleted a comment from vmwclabot Dec 13, 2024
@vmware vmware deleted a comment from vmwclabot Dec 13, 2024
@tenthirtyam tenthirtyam self-requested a review December 13, 2024 18:17
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vivgoyal vivgoyal merged commit f755b93 into main Dec 13, 2024
5 of 7 checks passed
@vivgoyal vivgoyal deleted the remove-integration branch December 13, 2024 18:40
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Breaking Change chore Chore documentation Documentation github-actions GitHub Actions provider Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants