Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix for eks cluster and nodepool tag issue #463

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

gusainsandhya
Copy link
Contributor

@gusainsandhya gusainsandhya commented Nov 19, 2024

Summary

Change in the order in which cluster and nodepool are updated.
This PR fixes the issue of nodepool tags not getting updated after the tags are removed from cluster and added to nodepool in the same resource file.

Type

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Additional Information

Verification :-

  1. Add a tag in the cluster. Now once the cluster tags are updated, remove the tag from cluster spec by using tags = { } and add it to the nodepool spec. The tag is removed from the cluster and added in the nodepool spec now.
  2. Add/Remove tags from nodepool works as expected.
  3. Add/Remove tags from cluster works as expected.

@vmwclabot
Copy link
Member

@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Nov 19, 2024
@github-actions github-actions bot added provider Provider needs-review Needs Review labels Nov 19, 2024
@tenthirtyam tenthirtyam requested a review from a team November 19, 2024 20:28
@vmwclabot vmwclabot removed the dco-required DCO Required label Nov 19, 2024
@gusainsandhya
Copy link
Contributor Author

@terraform-provider-tanzu-mission-control-maintainers can I get the review for this pull request please.

@gusainsandhya
Copy link
Contributor Author

@AkbaraliShaikh can you please take a look.

AkbaraliShaikh
AkbaraliShaikh previously approved these changes Nov 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.95%. Comparing base (3578fd2) to head (d757312).
Report is 70 commits behind head on main.

Files with missing lines Patch % Lines
...ternal/resources/ekscluster/resource_ekscluster.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3578fd2) and HEAD (d757312). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3578fd2) HEAD (d757312)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   25.23%   19.95%   -5.29%     
==========================================
  Files         195      264      +69     
  Lines       16908    23628    +6720     
==========================================
+ Hits         4267     4715     +448     
- Misses      12423    18699    +6276     
+ Partials      218      214       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vmwclabot
Copy link
Member

@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Dec 17, 2024
@vivgoyal vivgoyal added this to the .next milestone Dec 17, 2024
@vivgoyal vivgoyal linked an issue Dec 17, 2024 that may be closed by this pull request
@vivgoyal vivgoyal added bug Bug and removed dco-required DCO Required labels Dec 17, 2024
@vivgoyal vivgoyal changed the title Fix for eks cluster and nodepool tag issue bug: fix for eks cluster and nodepool tag issue Dec 17, 2024
@vmwclabot
Copy link
Member

@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Dec 17, 2024
@vivgoyal vivgoyal merged commit 042fde1 into vmware:main Dec 17, 2024
3 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug dco-required DCO Required needs-review Needs Review provider Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EKS Cluster Tag conflict with Nodepool Tags
5 participants