-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: fix for eks cluster and nodepool tag issue #463
Conversation
@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
137fe72
to
6aa1a00
Compare
@terraform-provider-tanzu-mission-control-maintainers can I get the review for this pull request please. |
@AkbaraliShaikh can you please take a look. |
Signed-off-by: Sandhya Gusain <[email protected]>
6aa1a00
to
fc567b7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
==========================================
- Coverage 25.23% 19.95% -5.29%
==========================================
Files 195 264 +69
Lines 16908 23628 +6720
==========================================
+ Hits 4267 4715 +448
- Misses 12423 18699 +6276
+ Partials 218 214 -4 ☔ View full report in Codecov by Sentry. |
@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
575fa4f
to
acba3a8
Compare
@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
acba3a8
to
8dee245
Compare
@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
e6bef26
to
09f05f7
Compare
@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
09f05f7
to
8dee245
Compare
@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
8dee245
to
5ba2196
Compare
b1fffdf
to
fc567b7
Compare
@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
8dee245
to
440cf90
Compare
@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
440cf90
to
e5233a2
Compare
@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
f23266e
to
fc567b7
Compare
@gusainsandhya, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Summary
Change in the order in which cluster and nodepool are updated.
This PR fixes the issue of nodepool tags not getting updated after the tags are removed from cluster and added to nodepool in the same resource file.
Type
Please describe:
Breaking Changes?
Test and Documentation
Issue References
Additional Information
Verification :-