Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UplinkHostSwitchProfile support #939

Merged
merged 1 commit into from
Aug 22, 2023
Merged

UplinkHostSwitchProfile support #939

merged 1 commit into from
Aug 22, 2023

Conversation

GraysonWu
Copy link
Collaborator

No description provided.

annakhm
annakhm reviewed Aug 10, 2023
View reviewed changes
nsxt/policy_common.go Outdated Show resolved Hide resolved
@GraysonWu GraysonWu force-pushed the host-switch-profile branch from 3e75f32 to 2101909 Compare August 10, 2023 19:58
@GraysonWu GraysonWu changed the title [WIP] Host Switch Profile support Host Switch Profile support Aug 16, 2023
@GraysonWu GraysonWu changed the title Host Switch Profile support UplinkHostSwitchProfile support Aug 17, 2023
@GraysonWu
Copy link
Collaborator Author

/test-all

@GraysonWu GraysonWu force-pushed the host-switch-profile branch 2 times, most recently from a3605c6 to bba6fda Compare August 18, 2023 00:46
@GraysonWu
Copy link
Collaborator Author

/test-all

@GraysonWu GraysonWu force-pushed the host-switch-profile branch from bba6fda to 2753a49 Compare August 18, 2023 03:51
@GraysonWu
Copy link
Collaborator Author

/test-all

2 similar comments
@GraysonWu
Copy link
Collaborator Author

/test-all

@annakhm
Copy link
Collaborator

annakhm commented Aug 21, 2023

/test-all

@annakhm
Copy link
Collaborator

annakhm commented Aug 21, 2023

Code LGTM, just a few cosmetic comments on docs. We also need to verify this policy-based profile can be referenced in MP-based transport node resource with no issues.

@GraysonWu GraysonWu force-pushed the host-switch-profile branch from 2753a49 to ca4fbba Compare August 21, 2023 22:30
annakhm
annakhm approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@annakhm annakhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration with transport node resource should work fine, since policy and non-policy API for host switch profiles return the same ID

@GraysonWu GraysonWu force-pushed the host-switch-profile branch from ca4fbba to 2d1afe4 Compare August 22, 2023 21:23
@GraysonWu GraysonWu merged commit 60cc731 into vmware:master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annakhm annakhm annakhm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GraysonWu @annakhm