Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EVPN VNI Pool resource #925

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

GraysonWu
Copy link
Collaborator

No description provided.

@GraysonWu GraysonWu force-pushed the evpn-vni-pool branch 2 times, most recently from 891897a to 4830883 Compare July 26, 2023 20:11
Signed-off-by: graysonwu <[email protected]>
@GraysonWu GraysonWu changed the title [WIP]Evpn vni pool Add EVPN VNI Pool resource Jul 26, 2023
@annakhm
Copy link
Collaborator

annakhm commented Jul 27, 2023

Thanks @GraysonWu, the resource looks good, please add documentation file for this resource

@GraysonWu
Copy link
Collaborator Author

Thanks @GraysonWu, the resource looks good, please add documentation file for this resource

Thanks @annakhm for reviewing. As for the documentation, I have a question: which subcategory should we use? I noticed that in the d/policy_vni_pool.html.markdown, we use subcategory: "Segments". But according to the API doc it falls in EVPN.
If we use EVPN as a subcategory, then I suppose we should update the d/policy_vni_pool.html.markdown to keep the consistency right?

@GraysonWu GraysonWu requested a review from annakhm July 28, 2023 19:13
@annakhm
Copy link
Collaborator

annakhm commented Jul 31, 2023

Thanks @GraysonWu, the resource looks good, please add documentation file for this resource

Thanks @annakhm for reviewing. As for the documentation, I have a question: which subcategory should we use? I noticed that in the d/policy_vni_pool.html.markdown, we use subcategory: "Segments". But according to the API doc it falls in EVPN. If we use EVPN as a subcategory, then I suppose we should update the d/policy_vni_pool.html.markdown to keep the consistency right?

Yes, sounds good to me

@annakhm
Copy link
Collaborator

annakhm commented Aug 1, 2023

/test-all

@annakhm
Copy link
Collaborator

annakhm commented Aug 1, 2023

Pls run make website-lint-fix to fix the linter error, thanks!

@GraysonWu
Copy link
Collaborator Author

/test-all

@GraysonWu
Copy link
Collaborator Author

/test-all

@GraysonWu GraysonWu requested a review from annakhm August 3, 2023 00:56
@annakhm
Copy link
Collaborator

annakhm commented Aug 3, 2023

/test-all

Signed-off-by: graysonwu <[email protected]>
@GraysonWu GraysonWu merged commit a96ecb6 into vmware:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants