-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VMC Oauth app support #1080
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsquan171
force-pushed
the
vmc-oauth
branch
2 times, most recently
from
January 9, 2024 23:06
44f4cf6
to
a1aee6a
Compare
/test-all |
annakhm
reviewed
Jan 10, 2024
wsquan171
force-pushed
the
vmc-oauth
branch
2 times, most recently
from
January 10, 2024 22:03
ec6567a
to
dadc2ab
Compare
/test-all |
wsquan171
force-pushed
the
vmc-oauth
branch
2 times, most recently
from
January 22, 2024 18:10
c589bcb
to
b0c81ef
Compare
/test-all |
2 similar comments
/test-all |
/test-all |
annakhm
approved these changes
Jan 23, 2024
annakhm
reviewed
Jan 23, 2024
This change adds support of NSX token exchange on VMC using Oauth app, which is a newer method compared to using refresh token. Signed-off-by: Shawn Wang <[email protected]>
Signed-off-by: Shawn Wang <[email protected]>
This reverts commit bc6d933. Signed-off-by: Shawn Wang <[email protected]>
Signed-off-by: Shawn Wang <[email protected]>
GraysonWu
pushed a commit
to GraysonWu/terraform-provider-nsxt
that referenced
this pull request
Jan 26, 2024
This change adds support of NSX token exchange on VMC using Oauth app, which is a newer method compared to using refresh token. Signed-off-by: Shawn Wang <[email protected]> Signed-off-by: graysonwu <[email protected]>
GraysonWu
added a commit
to GraysonWu/terraform-provider-nsxt
that referenced
this pull request
Jan 26, 2024
This reverts commit 08dff9f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support of NSX token exchange on VMC using Oauth app, which is a newer method compared to using refresh token.
Implementation mainly referenced python client for vmc on aws and terraform vmc provider.
Testing done:
With Oauth app created in server-to-server mode, assigned with all roles under "VMware Cloud on AWS" category, provider configured as:
Able to create and delete resources like:
For regression, verified using access token to create and delete the same resource. The provider is configured as follows:
e2e test covers non-vmc cases.
Closes #944