Add pagination to certificate data source #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-all |
|
Hi Shawn, I suggest to use |
Signed-off-by: Shawn Wang <[email protected]>
wsquan171
force-pushed
the
fix-cert-pagination
branch
from
988c164 to
2a43df8
Compare
|
/test-all |
Thanks. Fixed |
|
/test-all |
annakhm
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pagination support to certificate data source when getting a cert by name.
Fixes #849
Testing done:
Verified importing cert on NSX-T by name with overriding
info.LocalVarOptionals["pageSize"] = int64(20)while total cert count is 100.
Confirmed with debug log with proper pagination, for both found, not found and multiple found casaes.