Escape password when requesting for session token

When NSX password contains certain special characters(such as &), those need to be encoded when sent to session/create API Signed-off-by: Anna Khmelnitsky <[email protected]>
vmware · May 29, 2024 · ca4f98c · ca4f98c
1 parent f860e88
commit ca4f98c
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/nsxt/provider.go b/nsxt/provider.go
@@ -13,6 +13,7 @@ import (
 	"math/rand"
 	"net/http"
 	"net/http/httputil"
+	"net/url"
 	"os"
 	"regexp"
 	"strings"
@@ -554,6 +555,12 @@ func configureNsxtClient(d *schema.ResourceData, clients *nsxtClients) error {
 	username := d.Get("username").(string)
 	password := d.Get("password").(string)
 
+	// The correct place to escape special chars would be inside the SDK
+	// However since the SDK is deprecated, we implement escaping here
+	// TODO implement this functionality with new mp-sdk
+	username = url.QueryEscape(username)
+	password = url.QueryEscape(password)
+
 	if needCreds {
 		if username == "" {
 			return fmt.Errorf("username must be provided")