Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move to hcx package #73

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Jan 29, 2025

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Moves all resources and data sources from the main package to the hcx package and updated function references as needed.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added chore Chore technical-debt Technical Debt labels Jan 29, 2025
@tenthirtyam tenthirtyam added this to the v0.6.0 milestone Jan 29, 2025
@tenthirtyam tenthirtyam self-assigned this Jan 29, 2025
@github-actions github-actions bot added needs-review Needs Review provider Provider labels Jan 29, 2025
@tenthirtyam tenthirtyam marked this pull request as draft January 29, 2025 01:50
@tenthirtyam tenthirtyam added refactor Refactor and removed chore Chore labels Jan 29, 2025
@tenthirtyam tenthirtyam mentioned this pull request Jan 29, 2025
24 tasks
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jan 29, 2025
Copy link

@andybeltz andybeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam force-pushed the chore/move-to-hcx-package branch from 5ac1cf6 to bfcc4e2 Compare January 29, 2025 18:24
@github-actions github-actions bot added the needs-review Needs Review label Jan 29, 2025
@tenthirtyam tenthirtyam marked this pull request as ready for review January 29, 2025 18:25
Moves all resources and data sources from the `main` package to the `hcx` package.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the chore/move-to-hcx-package branch from bfcc4e2 to 98efa29 Compare January 29, 2025 21:31
@tenthirtyam tenthirtyam merged commit 1da32f2 into main Jan 29, 2025
5 checks passed
@tenthirtyam tenthirtyam deleted the chore/move-to-hcx-package branch January 29, 2025 21:34
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider Provider refactor Refactor technical-debt Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants