Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add debug #69

Merged
merged 1 commit into from
Jan 29, 2025
Merged

feat: add debug #69

merged 1 commit into from
Jan 29, 2025

Conversation

tenthirtyam
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Added capability to run the provider in debug mode, by passing "--debug" parameter.

Includes changes to the main.go file to add a debug mode for the provider. The most important changes include adding a flag for debug mode, parsing the flag, and updating the plugin.Serve call to use the debug mode if it is set.

  • Added a debug flag to enable debug mode (main.go).
  • Parsed the debug flag and updated the plugin.ServeOpts accordingly (main.go).
  • Set the ProviderAddr to "vmware/hcx" when debug mode is enabled (main.go).

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Added capability to run the provider in debug mode, by passing "--debug" parameter.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added the enhancement Enhancement label Jan 28, 2025
@tenthirtyam tenthirtyam added this to the v0.6.0 milestone Jan 28, 2025
@tenthirtyam tenthirtyam self-assigned this Jan 28, 2025
@github-actions github-actions bot added needs-review Needs Review provider Provider labels Jan 28, 2025
Copy link

@andybeltz andybeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam merged commit 479c5ab into main Jan 29, 2025
5 checks passed
@tenthirtyam tenthirtyam deleted the feat/add-debug branch January 29, 2025 18:23
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jan 29, 2025
@tenthirtyam tenthirtyam removed the request for review from spacegospod January 29, 2025 18:23
@tenthirtyam tenthirtyam mentioned this pull request Jan 29, 2025
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement provider Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants