Cleanup of mini_allocator.c . Add unit-tests to exercise this module. #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tapages This commit adds new print function to drive the functions for printing keyed / unkeyed metadata pages of the mini-allocator. Existing test cases are enhanced as follows to eventually exercise these print methods. - Extend splinter_test:test_splinter_print_diags() to exercise the print function that will walk through routing filter metadata pages for one pivot key and eventually calls mini_unkeyed_print(). - Modularize code in btree_stress_test.c to carve out code that is used to build new unit-test case, test_btree_print_diags(). First, this invokes btree_print_tree(), to see outputs of packed BTree node. Then, invokes mini_keyed_print(), to print keyed mini-allocator's metadata pages. - Add bunch of print functions in trunk.c to find out routing filter metadata pages and to invoke underlying print methods on such pages.
This commit refactors and does some minor cleanup of code in btree.c, mini_allocator.c and related files. Some page / extent number / offset boolean and conversion macros are added, along with unit-tests. No significant change in code-logic is being introduced with this fix.
…around refcount handling.
Add mini_deinit() to be used on the way out to dismantle a mini-allocator Add checks for num_extents used in test case. New test case sees to work ok, but other tests are failing due to changes done in trunk.c . Needs further investigation.
Add test-case to exercise mini_unkeyed_print(). Minor changes to print outputs from that function.
- In splinter_test, call to trunk_print_root_nodes_filter_metapages() is running into a seg-fault. This needs to be resolved under open issue #530. For now, comment out this call so that the rest of the test runs fine. - Minor comment updates in mini_allocator.c - Minor renaming of test code in mini_allocator_test.c - Full run of slow test.sh passes on Nimbus-VM. Test on CI now.
✅ Deploy Preview for splinterdb canceled.
|
|
Draft PR to shake-out some coding ideas / directions. Nothing more to be pursued. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR built on top of PR #531. Code cleanup and unit-tests added to
allocator.candmini_allocator.cSome smaller changes added to
allocator.handallocator.c, which should be peeled off to its own PR.Other cleanup / code consolidation done to
mini_allocator.c, along with unit-tests to exercise these interfaces.Start a draft PR to see how the rest of the tests fare under CI.