Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update backup message #95

Merged
merged 1 commit into from
Feb 18, 2023
Merged

fix: update backup message #95

merged 1 commit into from
Feb 18, 2023

Conversation

tenthirtyam
Copy link
Collaborator

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Updates the backup message to remove the SDDC Manager FQDN f when backups are located on the SDDC Manager. Must be addressed for HRM alerts.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added bug Bug size/xs Relative Sizing: extra-small report/health Health Report labels Feb 17, 2023
@tenthirtyam tenthirtyam added this to the v1.1.0 milestone Feb 17, 2023
@tenthirtyam tenthirtyam requested a review from a team as a code owner February 17, 2023 20:45
@tenthirtyam tenthirtyam self-assigned this Feb 17, 2023
Updates the backup message to remove the SDDC Manager FQDN f when backups are located on the SDDC Manager. Must be addressed for HRM alerts.

Signed-off-by: Ryan Johnson <[email protected]>
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake merged commit 489ee82 into main Feb 18, 2023
@GaryJBlake GaryJBlake deleted the fix/backup-msg branch February 18, 2023 11:43
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report/health Health Report size/xs Relative Sizing: extra-small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants