Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: specify encoding for Out-File #93

Merged
merged 2 commits into from
Feb 17, 2023
Merged

enhancement: specify encoding for Out-File #93

merged 2 commits into from
Feb 17, 2023

Conversation

bhumitra
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request
Out-File is used to create Json files in Publish-* cmdlets. We need to specify encoding for the generated file so that python script can read it properly. Needed for HRM.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@bhumitra bhumitra requested a review from a team as a code owner February 16, 2023 23:45
@github-actions github-actions bot added the needs-review Needs Review label Feb 16, 2023
@tenthirtyam tenthirtyam added this to the v1.1.0 milestone Feb 17, 2023
@vmwclabot vmwclabot added the dco-required DCO Required label Feb 17, 2023
tenthirtyam
tenthirtyam approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor updates in 0088c61.

@tenthirtyam tenthirtyam force-pushed the enhancement-for-out-file branch from 0088c61 to 928b63f Compare February 17, 2023 19:15
@tenthirtyam tenthirtyam force-pushed the enhancement-for-out-file branch from 928b63f to 2d53328 Compare February 17, 2023 19:15
@vmwclabot vmwclabot removed the dco-required DCO Required label Feb 17, 2023
@vmware vmware deleted a comment from vmwclabot Feb 17, 2023
@vmware vmware deleted a comment from vmwclabot Feb 17, 2023
@tenthirtyam tenthirtyam added enhancement Enhancement size/xs Relative Sizing: extra-small and removed needs-review Needs Review labels Feb 17, 2023
@tenthirtyam tenthirtyam merged commit 01ebdae into vmware:main Feb 17, 2023
@bhumitra bhumitra deleted the enhancement-for-out-file branch March 17, 2023 19:22
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@bhumitra bhumitra

Labels
enhancement Enhancement size/xs Relative Sizing: extra-small
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bhumitra @tenthirtyam @vmwclabot