Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vcf+ subscription cores #87

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

tenthirtyam
Copy link
Collaborator

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Adds an option to Request-ESXiOverview to report on the VCF+ subscription cores and export the results to CSV.

Adds Start-CreateOutputCsvDirectory function.

Signed-off-by: Ryan Johnson [email protected]

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #78

Test and Documentation Coverage

  • Tests have been completed (for bug fixes/features).
  • Documentation has been added/updated (for bug fixes/features).
PS F:\VMware.CloudFoundation.Reporting> Request-EsxiOverview -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -subscription -outputCsv F:\Reporting\csv
CSV file saved to F:\Reporting\csv\02-06-2023_07_14_09-sfo-vcf01.sfo.rainpole.io.csv

PS F:\VMware.CloudFoundation.Reporting> Request-EsxiOverview -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -subscription

Domain Name                  : sfo-m01
Cluster Name                 : sfo-m01-cl01
ESXi Host FQDN               : sfo01-m01-esx01.sfo.rainpole.io
ESXi Host Version            : 7.0.3-20328353
Hardware OEM                 : Dell Inc.
Hardware Platform            : PowerEdge R630
CPU Sockets                  : 2
CPU Cores                    : 28
CPU Cores per Socket         : 14
Memory (GB)                  : 256
VCF+ Subscription Core Count : 32
Status                       : ASSIGNED

Domain Name                  : sfo-m01
Cluster Name                 : sfo-m01-cl01
ESXi Host FQDN               : sfo01-m01-esx02.sfo.rainpole.io
ESXi Host Version            : 7.0.3-20328353
Hardware OEM                 : Dell Inc.
Hardware Platform            : PowerEdge R630
CPU Sockets                  : 2
CPU Cores                    : 28
CPU Cores per Socket         : 14
Memory (GB)                  : 256
VCF+ Subscription Core Count : 32
Status                       : ASSIGNED

Domain Name                  : sfo-m01
Cluster Name                 : sfo-m01-cl01
ESXi Host FQDN               : sfo01-m01-esx03.sfo.rainpole.io
ESXi Host Version            : 7.0.3-20328353
Hardware OEM                 : Dell Inc.
Hardware Platform            : PowerEdge R630
CPU Sockets                  : 2
CPU Cores                    : 28
CPU Cores per Socket         : 14
Memory (GB)                  : 256
VCF+ Subscription Core Count : 32
Status                       : ASSIGNED

Domain Name                  : sfo-m01
Cluster Name                 : sfo-m01-cl01
ESXi Host FQDN               : sfo01-m01-esx04.sfo.rainpole.io
ESXi Host Version            : 7.0.3-20328353
Hardware OEM                 : Dell Inc.
Hardware Platform            : PowerEdge R630
CPU Sockets                  : 2
CPU Cores                    : 28
CPU Cores per Socket         : 14
Memory (GB)                  : 256
VCF+ Subscription Core Count : 32
Status                       : ASSIGNED

Domain Name                  : sfo-w01
Cluster Name                 : sfo-w01-cl01
ESXi Host FQDN               : sfo01-w01-esx01.sfo.rainpole.io
ESXi Host Version            : 7.0.3-20328353
Hardware OEM                 : Dell Inc.
Hardware Platform            : PowerEdge R630
CPU Sockets                  : 2
CPU Cores                    : 28
CPU Cores per Socket         : 14
Memory (GB)                  : 256
VCF+ Subscription Core Count : 32
Status                       : ASSIGNED

Domain Name                  : sfo-w01
Cluster Name                 : sfo-w01-cl01
ESXi Host FQDN               : sfo01-w01-esx03.sfo.rainpole.io
ESXi Host Version            : 7.0.3-20328353
Hardware OEM                 : Dell Inc.
Hardware Platform            : PowerEdge R630
CPU Sockets                  : 2
CPU Cores                    : 28
CPU Cores per Socket         : 14
Memory (GB)                  : 256
VCF+ Subscription Core Count : 32
Status                       : ASSIGNED

Domain Name                  : sfo-w01
Cluster Name                 : sfo-w01-cl01
ESXi Host FQDN               : sfo01-w01-esx04.sfo.rainpole.io
ESXi Host Version            : 7.0.3-20328353
Hardware OEM                 : Dell Inc.
Hardware Platform            : PowerEdge R630
CPU Sockets                  : 2
CPU Cores                    : 28
CPU Cores per Socket         : 14
Memory (GB)                  : 256
VCF+ Subscription Core Count : 32
Status                       : ASSIGNED

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Adds an option to `Request-ESXiOverview` to report on the VCF+ subscription cores and export the results to CSV.

Adds `Start-CreateOutputCsvDirectory` function.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added the enhancement Enhancement label Feb 6, 2023
@tenthirtyam tenthirtyam added this to the v1.1.0 milestone Feb 6, 2023
@tenthirtyam tenthirtyam requested a review from a team as a code owner February 6, 2023 19:19
@tenthirtyam tenthirtyam self-assigned this Feb 6, 2023
@tenthirtyam tenthirtyam marked this pull request as draft February 6, 2023 19:19
@tenthirtyam tenthirtyam marked this pull request as ready for review February 7, 2023 14:31
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake merged commit 428f051 into main Feb 7, 2023
@GaryJBlake GaryJBlake deleted the feat/add-vcfplus-subscription-cores branch February 7, 2023 14:48
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to report the total number of CPU cores per CPU Socket
2 participants