Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overview): exclude hcx hosts #65

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

tenthirtyam
Copy link
Collaborator

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Updates Request0VcenterOverview to use the PowerVCF cmdlets to return the workload domain's cluster and host counts from the SDDC Manager inventory versus directly from the vSphere inventory. This will ensure that the host count does not include any HCX nodes and addresses #44.

Signed-off-by: Ryan Johnson [email protected]

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #44

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Updates `Request0VcenterOverview` to use the PowerVCF cmdlets to return the workload domain's cluster and host counts from the SDDC Manager inventory versus directly from the vSphere inventory. This will ensure that the host count does not include any HCX nodes and addresses #44.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added the bug Bug label Jan 3, 2023
@tenthirtyam tenthirtyam added this to the v1.0.6 milestone Jan 3, 2023
@tenthirtyam tenthirtyam requested a review from a team as a code owner January 3, 2023 15:02
@tenthirtyam tenthirtyam self-assigned this Jan 3, 2023
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake merged commit 6fed300 into main Jan 3, 2023
@GaryJBlake GaryJBlake deleted the fix(overview)/exclude-hcx branch January 3, 2023 15:13
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for removing HCX ESXi hosts from System Overview Report host count
2 participants