Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error in variable passed to Publish-NsxtHealth #59

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

GaryJBlake
Copy link
Contributor

@GaryJBlake GaryJBlake commented Dec 23, 2022

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

When calling Publish-NsxtHealth, Publish-NsxtCombinedHealth is passing $jsonFilePath instead of $json.

Signed-off-by: Gary Blake [email protected]

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.

Related to Existing Issues

Issue Number: Closes #58

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

When calling  `Publish-NsxtHealth, `Publish-NsxtCombinedHealth` is passing $jsonFilePath instead of $json

Signed-off-by: Gary Blake <[email protected]>
@GaryJBlake GaryJBlake added bug Bug size/xs Relative Sizing: extra-small report/health Health Report labels Dec 23, 2022
@GaryJBlake GaryJBlake added this to the v1.0.6 milestone Dec 23, 2022
@GaryJBlake GaryJBlake requested a review from a team as a code owner December 23, 2022 12:05
@GaryJBlake GaryJBlake self-assigned this Dec 23, 2022
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@GaryJBlake GaryJBlake merged commit a80eea2 into main Dec 23, 2022
@GaryJBlake GaryJBlake deleted the fix-error-in-json-for-Publish-NsxtCombinedHealth branch December 23, 2022 14:21
@tenthirtyam tenthirtyam changed the title fix: error in variable passed to Publish-NsxtHealth fix: error in variable passed to Publish-NsxtHealth Jan 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report/health Health Report size/xs Relative Sizing: extra-small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in $jsonFilePath when running health report
2 participants