Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for additional json outputs #204

Merged

Conversation

lelik2be
Copy link
Contributor

@lelik2be lelik2be commented Dec 20, 2023

Summary

  1. Updated the following cmdlets to generate JSON output:

    • Publish-VmConnectedCdrom
    • Publish-EsxiConnectionHealth
    • Publish-SddcManagerFreePool
  2. Updated cmdlet documentation and examples.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Ran Publish-SnapshotStatus, Publish-EsxiConnectionHealth and Publish-SddcManagerFreePool cmdlets with
[-outputJson \'<String'>] parameter. As result respective JSONs were generated.

Issue References

Additional Information

@lelik2be lelik2be requested a review from a team as a code owner December 20, 2023 23:44
@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Dec 20, 2023
@tenthirtyam tenthirtyam force-pushed the add-output-json-to-publish-methods branch from 9faa68d to 394043b Compare December 21, 2023 00:06
@tenthirtyam tenthirtyam changed the title Updated Reporting Module to be able to generate JSON file. feat: add support for additional json outputs Dec 21, 2023
@tenthirtyam tenthirtyam added enhancement Enhancement and removed needs-review Needs Review labels Dec 21, 2023
@tenthirtyam tenthirtyam added this to the v2.6.0 milestone Dec 21, 2023
@github-actions github-actions bot added the needs-review Needs Review label Dec 21, 2023
- Updated `Publish-VmConnectedCdrom` function to generate JSON output.
- Updated `Publish-EsxiConnectionHealth` function to generate JSON output.
- Updated `Publish-SddcManagerFreePool` function to generate JSON output.

Signed-off-by: olga efremov <[email protected]>
@tenthirtyam tenthirtyam force-pushed the add-output-json-to-publish-methods branch from 394043b to d28cb1f Compare December 21, 2023 00:21
@tenthirtyam tenthirtyam self-requested a review December 21, 2023 00:21
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I went ahead and updates the CHANGELOG.md and ModuleVersion.

@tenthirtyam tenthirtyam merged commit 865dbcb into vmware:develop Dec 21, 2023
1 check passed
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jan 10, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants