Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: module dependencies #155

Merged
merged 4 commits into from
Jul 17, 2023
Merged

fix: module dependencies #155

merged 4 commits into from
Jul 17, 2023

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Jun 30, 2023 •
edited
Loading

Summary

  • Added the RequiredModules key to the module manifest to specify the minimum dependencies required to install and run the PowerShell module.
  • Updated Test-VcfReportingPrereq to verify that the minimum dependencies are met to run the PowerShell module based on the module's manifest.
  • Bumps PowerValidatedSolutions dependency to v2.5.0 (next release) in the manifest.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.

    Microsoft Windows:

    PS F:\VMware.CloudFoundation.Reporting> Test-VcfReportingPrereq -sddcManagerFqdn sfo-vcf01.sfo.rainpole.io -sddcManagerUser admin@local -sddcManagerPass VMw@re1!VMw@re1!

[07-17-2023_17:43:05] [INFO] VMware Cloud Foundation: SDDC Manager 4.5.1.0 (sfo-vcf01.sfo.rainpole.io) and supports the minimum required version.
[07-17-2023_17:43:05] [INFO] VMware.vSphere.SsoAdmin 1.3.9 is installed version and meets the minimum required version of VMware.vSphere.SsoAdmin 1.3.9.
[07-17-2023_17:43:05] [INFO] PowerVCF 2.3.0.1003 is installed version and meets the minimum required version of PowerVCF 2.3.0.
[07-17-2023_17:43:05] [INFO] PowerValidatedSolutions 2.5.0.1006 is installed version and meets the minimum required version of PowerValidatedSolutions 2.5.0.

    VMware Photon OS:

    PS /home/vmware/VMware.CloudFoundation.Reporting> Test-VcfReportingPrereq -sddcManagerFqdn sfo-vcf01.sfo.rainpole.io -sddcManagerUser admin@local -sddcManagerPass VMw@re1!VMw@re1!

[07-17-2023_16:54:37] [INFO] VMware Cloud Foundation: SDDC Manager 4.5.1.0 (sfo-vcf01.sfo.rainpole.io) and supports the minimum required version.
[07-17-2023_16:54:37] [INFO] VMware.vSphere.SsoAdmin 1.3.9 is installed version and meets the minimum required version of VMware.vSphere.SsoAdmin 1.3.9.
[07-17-2023_16:54:37] [INFO] PowerVCF 2.3.0.1004 is installed version and meets the minimum required version of PowerVCF 2.3.0.
[07-17-2023_16:54:37] [INFO] PowerValidatedSolutions 2.5.0.1003 is installed version and meets the minimum required version of PowerValidatedSolutions 2.5.0.

  • Documentation has been added or updated.
    Note: To be updated for release.

Issue References

Closes #153

Updating PowerValidatedSolutions dependency to v2.5.0 (next release) in the manifest brings in the changes needed for #153.

Additional Information

@tenthirtyam tenthirtyam added chore Chore dependencies Dependencies labels Jun 30, 2023
@tenthirtyam tenthirtyam added this to the v2.3.0 milestone Jun 30, 2023
@tenthirtyam tenthirtyam self-assigned this Jun 30, 2023
@tenthirtyam tenthirtyam force-pushed the fix/module-dependencies branch 2 times, most recently from d0e42df to ed54892 Compare June 30, 2023 00:53
fix: module dependencies
23399f7 
- Added the `RequiredModules` key to the module manifest to specify the minimum dependencies required to install and run the PowerShell module.
- Updated `Test-VcfReportingPrereq` to verify that the minimum dependencies are met to run the PowerShell module based on the module's manifest.
- Bumps `PowerValidatedSolutions` dependency to v2.5.0 (next release) in the manifest.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the fix/module-dependencies branch from ed54892 to 23399f7 Compare July 17, 2023 15:26
fix: module dependencies
708cd2b 
- Added the `RequiredModules` key to the module manifest to specify the minimum dependencies required to install and run the PowerShell module.
- Updated `Test-VcfReportingPrereq` to verify that the minimum dependencies are met to run the PowerShell module based on the module's manifest.
- Bumps `PowerValidatedSolutions` dependency to v2.5.0 (next release) in the manifest.

Signed-off-by: Ryan Johnson <[email protected]>
@vmwclabot vmwclabot added the dco-required DCO Required label Jul 17, 2023
@tenthirtyam tenthirtyam force-pushed the fix/module-dependencies branch from 304e5a8 to cbaaf52 Compare July 17, 2023 15:27
@vmwclabot vmwclabot removed the dco-required DCO Required label Jul 17, 2023
@vmware vmware deleted a comment from vmwclabot Jul 17, 2023
fix: minor fix
32b1074 
Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam marked this pull request as ready for review July 17, 2023 16:53
@tenthirtyam tenthirtyam requested a review from a team as a code owner July 17, 2023 16:53
@tenthirtyam tenthirtyam requested review from bhumitra and GaryJBlake and removed request for a team July 17, 2023 16:53
@tenthirtyam tenthirtyam added the needs-review Needs Review label Jul 17, 2023
@tenthirtyam tenthirtyam merged commit e29da98 into main Jul 17, 2023
@tenthirtyam tenthirtyam deleted the fix/module-dependencies branch July 17, 2023 23:22
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jul 17, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bhumitra bhumitra bhumitra approved these changes

@GaryJBlake GaryJBlake Awaiting requested review from GaryJBlake

Assignees

@tenthirtyam tenthirtyam

Labels
chore Chore dependencies Dependencies
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.

Request-VcenterBackupStatus returns incorrect results
3 participants
@tenthirtyam @bhumitra @vmwclabot