Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Publish-StorageCapacityHealth cmdlet #148

Merged

Conversation

bhumitra
Copy link
Contributor

@bhumitra bhumitra commented Jun 14, 2023

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Updated Publish-StorageCapacityHealth cmdlet.
  • Updated module version to 2.2.0.1000.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #147

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@bhumitra bhumitra requested a review from a team as a code owner June 14, 2023 03:43
@github-actions github-actions bot added the needs-review Needs Review label Jun 14, 2023
@tenthirtyam tenthirtyam changed the title Fix publish storage capacity health function fix: update Publish-StorageCapacityHealth cmdlet Jun 14, 2023
tenthirtyam
tenthirtyam previously approved these changes Jun 14, 2023
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam requested a review from GaryJBlake June 14, 2023 13:54
@tenthirtyam tenthirtyam added this to the v2.2.0 milestone Jun 14, 2023
@tenthirtyam tenthirtyam force-pushed the fix-publish-storage-capacity-health-function branch from 2ca4d30 to 2e0c573 Compare June 14, 2023 16:23
@tenthirtyam tenthirtyam merged commit f4c455b into vmware:main Jun 14, 2023
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jun 20, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish-StorageCapacityHealth failing with Error at Script Line 3736
2 participants