Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Request-NetworkOverview #133

Merged
merged 1 commit into from
May 3, 2023

Conversation

tenthirtyam
Copy link
Collaborator

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Updates Request-NetworkOverview to resolve a bug introduced in #130.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Related #130

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).
PS F:\VMware.CloudFoundation.Reporting> Request-NetworkOverview -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1!


NSX Manager Cluster FQDN : sfo-m01-nsx01.sfo.rainpole.io
Version                  : 4.1.0.0.0-21180617
Domain Name              : sfo-m01
Domain Type              : management
Shared                   : False
Size                     : medium
CPU                      : 6
Memory (GB)              : 24
Edge Cluster             : True
AVN                      : True

NSX Manager Cluster FQDN : sfo-w01-nsx01.sfo.rainpole.io
Version                  : 4.1.0.0.0-21180617
Domain Name              : sfo-w01
Domain Type              : vi
Shared                   : True
Size                     : large
CPU                      : 12
Memory (GB)              : 48
Edge Cluster             : False
AVN                      : False

PS F:\VMware.CloudFoundation.Reporting>

image

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added bug Bug report/overview Overview Report labels May 2, 2023
@tenthirtyam tenthirtyam added this to the v2.1.0 milestone May 2, 2023
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 2, 2023 20:13
@tenthirtyam tenthirtyam self-assigned this May 2, 2023
- Updates `Request-NetworkOverview` to resolve a bug introduced in #130.
- Updates module version from v2.1.0.1004 to v2.1.0.1005.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the fix/update-networking-overview branch from e63744d to e1bce99 Compare May 2, 2023 20:37
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake merged commit 8916d84 into main May 3, 2023
@GaryJBlake GaryJBlake deleted the fix/update-networking-overview branch May 3, 2023 07:30
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report/overview Overview Report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants