Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: isolated workload domains #131

Merged
merged 1 commit into from
May 2, 2023

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Apr 25, 2023

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Updated Request-VcenterAuthentication to support isolated workload domains.
  • Updated Request-DatastoreStorageCapacity to support isolated workload domains.
  • Updated CHANGELOG.md.
  • Updated module version from v2.1.0.1002 to v2.1.0.1003.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Ref: #106

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Results: Isolated Workload Domains

PS C:\Users\Administrator> Request-VcenterAuthentication -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -allDomains

Component Resource                     Alert Message
--------- --------                     ----- -------
vCenter   sfo-m01-vc01.sfo.rainpole.io GREEN API Connection check successful!
vCenter   sfo-w01-vc01.sfo.rainpole.io GREEN API Connection check successful!

PS C:\Users\Administrator> Request-VcenterAuthentication -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -workloadDomain sfo-m01

Component Resource                     Alert Message
--------- --------                     ----- -------
vCenter   sfo-m01-vc01.sfo.rainpole.io GREEN API Connection check successful!

PS C:\Users\Administrator> Request-VcenterAuthentication -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -workloadDomain sfo-w01

Component Resource                     Alert Message
--------- --------                     ----- -------
vCenter   sfo-w01-vc01.sfo.rainpole.io GREEN API Connection check successful!

PS C:\Users\Administrator> Request-VcenterAuthentication -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -allDomains -failureOnly

Results: Non-Isolated Workload Domains

PS F:\>  Request-VcenterAuthentication -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -allDomains

Component Resource                     Alert Message
--------- --------                     ----- -------
vCenter   sfo-m01-vc01.sfo.rainpole.io RED   API Connection check failed!
vCenter   sfo-w01-vc01.sfo.rainpole.io GREEN API Connection check successful!

PS F:\>  Request-VcenterAuthentication -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -workloadDomain sfo-m01

Component Resource                     Alert Message
--------- --------                     ----- -------
vCenter   sfo-m01-vc01.sfo.rainpole.io RED   API Connection check failed!

PS F:\>  Request-VcenterAuthentication -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -workloadDomain sfo-w01

Component Resource                     Alert Message
--------- --------                     ----- -------
vCenter   sfo-w01-vc01.sfo.rainpole.io GREEN API Connection check successful!

PS F:\>  Request-VcenterAuthentication -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -allDomains -failureOnly

Component Resource                     Alert Message
--------- --------                     ----- -------
vCenter   sfo-m01-vc01.sfo.rainpole.io RED   API Connection check failed!

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added refactor Refactor report/health Health Report labels Apr 25, 2023
@tenthirtyam tenthirtyam added this to the v2.1.0 milestone Apr 25, 2023
@tenthirtyam tenthirtyam self-assigned this Apr 25, 2023
@tenthirtyam tenthirtyam force-pushed the refactor/isolated-workload-domains branch from 683f3a6 to 4129e4b Compare April 25, 2023 21:17
@tenthirtyam tenthirtyam requested a review from GaryJBlake April 25, 2023 21:18
@tenthirtyam tenthirtyam marked this pull request as ready for review April 25, 2023 21:18
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 25, 2023 21:18
- Updated `Request-VcenterAuthentication` to support isolated workload domains.
- Updated `Request-DatastoreStorageCapacity` to support isolated workload domains.
- Updated `CHANGELOG.md`.
- Updated module version from v2.1.0.1002 to v2.1.0.1003.

Ref: #106

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the refactor/isolated-workload-domains branch from 4129e4b to 4b2050a Compare April 25, 2023 21:35
@tenthirtyam tenthirtyam mentioned this pull request May 2, 2023
11 tasks
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake merged commit aa8c2fc into main May 2, 2023
@tenthirtyam tenthirtyam deleted the refactor/isolated-workload-domains branch May 2, 2023 18:45
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Refactor report/health Health Report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants