Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update branding #128

Merged
merged 2 commits into from
Apr 18, 2023
Merged

refactor: update branding #128

merged 2 commits into from
Apr 18, 2023

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Apr 17, 2023 •
edited
Loading

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Breaking Renamed Request-VrealizeOverview to Request-VMwareAriaSuiteOverview and updated outputs to reflect the rebranded product names.
  • Bumps the module version to v2.0.0.1012.
  • Updates CHANGELOG.md.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #127

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).
PS F:\> Request-VMwareAriaSuiteOverview -server sfo-vcf01.sfo.rainpole.io -user admin@local -pass VMw@re1!VMw@re1! -anonymized

VMware Aria Suite Product : VMware Aria Suite Lifecycle
UUID                      : 0e57d43f-761a-4389-a812-3bf5218932d1
Version                   : 8.10.0-20594451
Status                    : ACTIVE
Nodes                     : 1

VMware Aria Suite Product : VMware Workspace ONE Access
UUID                      : globalenvironment:wsa
Version                   : 3.3.6-19203469
Status                    : ACTIVE
Nodes                     : 3

VMware Aria Suite Product : VMware Aria Operations for Logs
UUID                      : 96a16e10-e396-43dd-b08d-55303cf6294c:vrli
Version                   : 8.8.2-20056468
Status                    : ACTIVE
Nodes                     : 3

VMware Aria Suite Product : VMware Aria Operations
UUID                      : 3e74dfe1-366c-486f-bfc9-625247407573:vrops
Version                   : 8.10.0-20570121
Status                    : ACTIVE
Nodes                     : 3

VMware Aria Suite Product : VMware Aria Automation
UUID                      : 3e74dfe1-366c-486f-bfc9-625247407573:vra
Version                   : 8.10.0-20566543
Status                    : ACTIVE
Nodes                     : 3

image

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

refactor: update branding
e2e0057 
- **Breaking** Renamed `Request-VrealizeOverview` to `Request-VMwareAriaSuiteOverview` and updated outputs to reflect the rebranded product names.
- Bumps the module version to v2.0.0.1012.
- Updates `CHANGELOG.md`.

Ref: #127

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added breaking-change Breaking Change refactor Refactor labels Apr 17, 2023
@tenthirtyam tenthirtyam added this to the v2.0.0 milestone Apr 17, 2023
@tenthirtyam tenthirtyam self-assigned this Apr 17, 2023
@tenthirtyam tenthirtyam requested a review from GaryJBlake April 17, 2023 21:28
GaryJBlake
GaryJBlake approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vmwclabot vmwclabot added the dco-required DCO Required label Apr 18, 2023
@vmware vmware deleted a comment from vmwclabot Apr 18, 2023
@tenthirtyam tenthirtyam removed the dco-required DCO Required label Apr 18, 2023
@tenthirtyam tenthirtyam marked this pull request as ready for review April 18, 2023 13:38
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 18, 2023 13:38
@tenthirtyam tenthirtyam requested a review from GaryJBlake April 18, 2023 13:38
GaryJBlake
GaryJBlake approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake merged commit 256bc1d into main Apr 18, 2023
@tenthirtyam tenthirtyam deleted the refactor/vrealize-to-aria branch April 24, 2023 14:46
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GaryJBlake GaryJBlake GaryJBlake approved these changes

Assignees

@tenthirtyam tenthirtyam

Labels
breaking-change Breaking Change refactor Refactor
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Update the module for VMware Aria branding
3 participants
@tenthirtyam @GaryJBlake @vmwclabot