-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove Publish-LocalUserExpiry
support functions
#120
Conversation
a8eb2d3
to
28ed79b
Compare
6faa568
to
4544547
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- Removed `Request-LocalUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-SddcManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-vCenterUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtEdgeUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-Request-vRslcmUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Updates incorrect parameter names in examples and descriptions. - Updates `CHANGELOG.md`. Ref: #111 Signed-off-by: Ryan Johnson <[email protected]>
4544547
to
49c5117
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.
Summary of Pull Request
Request-LocalUserExpiry
which supported thePublish-LocalUserExpiry
cmdlet.Request-SddcManagerUserExpiry
which supported thePublish-LocalUserExpiry
cmdlet.Request-vCenterUserExpiry
which supported thePublish-LocalUserExpiry
cmdlet.Request-NsxtManagerUserExpiry
which supported thePublish-LocalUserExpiry
cmdlet.Request-NsxtEdgeUserExpiry
which supported thePublish-LocalUserExpiry
cmdlet.Request-Request-vRslcmUserExpiry
which supported thePublish-LocalUserExpiry
cmdlet.CHANGELOG.md
.Type of Pull Request
Please describe:
Related to Existing Issues
Ref: #111
Closes #89
Test and Documentation Coverage
Breaking Changes?