feat: adjust thresholds for certificate health

[bhumitra]

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

• Adjust thresholds for certificate health expiry
• Added ESXi hosts data back into the report
• Added certificate expires in days column to report

Type of Pull Request

• This is a bug fix.
• This is an enhancement or feature.
• This is a code style / formatting update.
• This is a documentation update.
• This is a refactoring update.
• This is a chore update
• This is something else.
  Please describe:

Related to Existing Issues

Closes #101

Test and Documentation Coverage

• Tests have been completed (for bug fixes / features).
• Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

• Yes, there are breaking changes.
• No, there are no breaking changes.

[bhumitra]

This is what it looks like now.

[tenthirtyam]

LGTM! 🚀

[tenthirtyam]

Error observed on Windows:

PS F:\VMware.CloudFoundation.Reporting> Import-Module .\VMware.CloudFoundation.Reporting.psd1
PS F:\VMware.CloudFoundation.Reporting> Publish-CertificateHealth -json F:\Reporting\HealthReports\sfo-w01-all-health-results.json
 [03-28-2023_14:17:05]   Error at Script Line 926
 [03-28-2023_14:17:05]   Relevant Command: $expiry = [DateTime]::ParseExact($element.title[2], "MMM dd HH:mm:ss yyyy 'GMT'", $null).ToUniversalTime()
 [03-28-2023_14:17:05]   Error Message: Exception calling "ParseExact" with "3" argument(s): "String was not recognized as a valid DateTime."
PS F:\VMware.CloudFoundation.Reporting> Publish-CertificateHealth -json F:\Reporting\HealthReports\sfo-vcf01-all-health-results.json
 [03-28-2023_14:17:22]   Error at Script Line 926
 [03-28-2023_14:17:22]   Relevant Command: $expiry = [DateTime]::ParseExact($element.title[2], "MMM dd HH:mm:ss yyyy 'GMT'", $null).ToUniversalTime()
 [03-28-2023_14:17:22]   Error Message: Exception calling "ParseExact" with "3" argument(s): "String was not recognized as a valid DateTime."

[tenthirtyam]

Marked as draft whilst awaiting changes.

[tenthirtyam]

Looks good after testing with the update but I do see an oddity where it’s reporting a -25 but an 8 day expiration. You can test with the JSON I provided over Slack. I suspect this is a data issue from SoS?

PS F:\VMware.CloudFoundation.Reporting> Publish-CertificateHealth -json F:\Reporting\HealthReports\sfo-vcf01-all-health-results.json -failureOnly


Component         : vRLI
Resource          : sfo-vrli01a.sfo.rainpole.io
Expires In (Days) : -25
Alert             : RED
Message           : Certificate validation is failed for vRLI:sfo-vrli01a.sfo.rainpole.io. If Certificate End date is 15 days or less, SoS will show result as failed.Certificate expires in 8
                    day(s).

[tenthirtyam]

I’ll submit an update for the build and changelog before merge.

Next review

[vmwclabot]

@bhumitra, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit c53b7a6 must be signed by [email protected]

[tenthirtyam]

LGTM! 🚀

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.