vcsim: fix save+load of Alarm objects #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougm
force-pushed
the
vcsim-load-alarm
branch
2 times, most recently
from
fb2a6d0 to
bf637fc
Compare
govc object.save includes Alarm objects, but vcsim -load did not wrap the Alarm objects. This causes panic when trying to call CreateAlarm() which expects wrapped Alarm objects. Signed-off-by: Doug MacEachern <[email protected]>
Signed-off-by: Doug MacEachern <[email protected]>
dougm
force-pushed
the
vcsim-load-alarm
branch
from
bf637fc to
8aefcdd
Compare
shihhaoli
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
govc object.save includes Alarm objects, but vcsim -load did not wrap the Alarm objects.
This causes panic when trying to call CreateAlarm() which expects wrapped Alarm objects.