Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update anyURI to url.URL #3123

Closed
wants to merge 1 commit into from

Conversation

akutz
Copy link
Member

@akutz akutz commented May 10, 2023

Description

This patch updates the existence of anyURI from the WSDL to be a url.URL instead of a string. Please note this is potentially a breaking change and consumers of GoVmomi will need to update any place they expected anyURI to be a string.

Please note we should not yet merge this PR as @dougm highlighted this type was originally url.URL but was changed in #1100. Until we recall why, we do not want to merge this PR.

Closes: NA

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

  • go build ./...
  • go test -v ./vim25/types
  • GitHub actions.

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

This patch updates the existence of anyURI from the
WSDL to be a url.URL instead of a string. Please note
this is potentially a breaking change and consumers
of GoVmomi will need to update any place they expected
anyURI to be a string.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Mark as fresh by adding the comment /remove-lifecycle stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants