Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch updates the existence of anyURI from the WSDL to be a url.URL instead of a string. Please note this is potentially a breaking change and consumers of GoVmomi will need to update any place they expected anyURI to be a string.
Please note we should not yet merge this PR as @dougm highlighted this type was originally
url.URL
but was changed in #1100. Until we recall why, we do not want to merge this PR.Closes:
NA
Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
go build ./...
go test -v ./vim25/types
Checklist:
CONTRIBUTION
guidelines of this project