Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: byte, float and int (de) serialization #3122

Merged
merged 1 commit into from
May 11, 2023

Conversation

karaatanassov
Copy link
Contributor

Description

Added mapping for float.
Fixed the mappings for byte to use uint8.
Changed type name lookup order to use the external mapping before built-in table. This fixes int deserialization.

Closes: #3121

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

  • Added OptionValue (De)serialization tests
  • Run locally go test ./...

Checklist:

  • My code follows the CONTRIBUTION
    guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Added mapping for float.
Fixed the mappings for byte to use uint8.
Changed type name lookup order to use the external mapping before
built-in table. This fixes int deserialization.

Closes vmware#3121
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karaatanassov karaatanassov merged commit a939567 into vmware:main May 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] JSON (de)serializaiton of byte and float OptionValue in JSON fails
3 participants