-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Panic when updating vcsim map with partial updates to a field #3349
Comments
brakthehack
added a commit
to brakthehack/govmomi
that referenced
this issue
Jan 30, 2024
A previous change reverted behavior that ignored indexed property updates in favor of a panic. While we don't implement persistence for partial updates, some consumers rely on this behavior to test property collector updates on specific fields. This change reverts a03f4735570027d2e6e2bc9cb7584a0af19f9353q to the previous behavior allowing downstream consumers to rely on this field for testing PC updates until full support for indexed fields is implemented. Closes vmware#3349
brakthehack
added a commit
to brakthehack/govmomi
that referenced
this issue
Jan 30, 2024
A previous change reverted behavior that ignored indexed property updates in favor of a panic. While we don't implement persistence for partial updates, some consumers rely on this behavior to test property collector updates on specific fields. This change reverts a03f4735570027d2e6e2bc9cb7584a0af19f9353q to the previous behavior allowing downstream consumers to rely on this field for testing PC updates until full support for indexed fields is implemented. Closes vmware#3349
12 tasks
hickeng
pushed a commit
to hickeng/govmomi
that referenced
this issue
Jan 31, 2024
A previous change reverted behavior that ignored indexed property updates in favor of a panic. While we don't implement persistence for partial updates, some consumers rely on this behavior to test property collector updates on specific fields. This change reverts a03f4735570027d2e6e2bc9cb7584a0af19f9353q to the previous behavior allowing downstream consumers to rely on this field for testing PC updates until full support for indexed fields is implemented. Closes vmware#3349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Prior to a recent change, we previously were able to trigger property collector notifications for singular items in a list by specifying the listed indexed by item key. One example of this is waiting for updates on specific VC extensions. E.g.
extensionList["my-extension"]
.Now when we try to perform an update via the
simulator.Map.Update
API while supplying a field along with an extension key, we panic.To Reproduce
Steps to reproduce the behavior:
Attempt to perform incremental property changes by specifying a key to a list.
Expected behavior
The underlying list shouldn't be changed, but a property collector update should be fired on the specific
newExtension
key.Affected version
All versions as of a03f4735570027d2e6e2bc9cb7584a0af19f9353q are effected.
Screenshots/Debug Output
If applicable, add screenshots or debug output to help explain your problem.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: