-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Go Benchmarks #329
Conversation
A few new benchmarks, which can be useful when validating improvements to the implementation. Signed-off-by: Antonin Bas <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
=======================================
Coverage 73.67% 73.67%
=======================================
Files 19 19
Lines 2800 2800
=======================================
Hits 2063 2063
Misses 572 572
Partials 165 165
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
While trying this benchmark locally, I found the IPv4 AddRecord and AggregateMsg benchmarks are approximately 20% slower than the IPv6 one.
Have you also seen similar results Antonin?
BenchmarkAddRecordIPv4Addresses-10 335524 3345 ns/op
BenchmarkAddRecordIPv6Addresses-10 404529 2855 ns/op
BenchmarkAggregateMsgByFlowKey/ipv4-10 58531 20586 ns/op
BenchmarkAggregateMsgByFlowKey/ipv6-10 82375 15100 ns/op
@dreamtalen For For
|
…sses Signed-off-by: Antonin Bas <[email protected]>
@dreamtalen I unified the test code, PTAL For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you. As expected, the IPv4 one now performs slightly better in both benchmark tests. |
A few new benchmarks, which can be useful when validating improvements to the implementation. Signed-off-by: Antonin Bas <[email protected]>
A few new benchmarks, which can be useful when validating improvements to the implementation. Signed-off-by: Antonin Bas <[email protected]>
A few new benchmarks, which can be useful when validating improvements to the implementation.