Skip to content

Commit

Permalink
Fix Docker builds for ipfix-collector and kafka-consumer (#368)
Browse files Browse the repository at this point in the history
The go version needs to be updated in the Dockerfiles.

We also make sure that the Github workflow which validates the Docker
builds is run for pull requests.

Signed-off-by: Antonin Bas <[email protected]>
  • Loading branch information
antoninbas committed Sep 12, 2024
1 parent a5e552a commit 06fc427
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ on:

jobs:
build-ipfix-collector:
if: ${{ github.event_name == 'push' }}
runs-on: [ubuntu-latest]
steps:
- uses: actions/checkout@v3
Expand All @@ -27,7 +26,6 @@ jobs:
echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
docker push antrea/ipfix-collector:latest
build-kafka-consumer:
if: ${{ github.event_name == 'push' }}
runs-on: [ubuntu-latest]
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion build/images/Dockerfile.build.collector
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.21 as go-ipfix-build
FROM golang:1.23 as go-ipfix-build

WORKDIR /go-ipfix

Expand Down
2 changes: 1 addition & 1 deletion build/images/Dockerfile.build.consumer
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.21 as go-ipfix-build
FROM golang:1.23 as go-ipfix-build

WORKDIR /go-ipfix

Expand Down

0 comments on commit 06fc427

Please sign in to comment.