Performance improvements #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see https://github.com/frankmcsherry/differential-dataflow/issues/113 - a new Variable implementation by Frank that reduces the cost of recursive variables by 1/3 - use distinct_total instead of distinct where safe - don't create recursive variables for non-recursive collections - use 32-bit timestamp for nested scopes
- differential moved to tag-based release model - use barrier synchronization to block worker threads instead of idling when there is no work to do
|
(merging without review as the current master is broken by differential update) |
mihaibudiu
reviewed
Sep 17, 2018
| @@ -0,0 +1,109 @@ | |||
| //! Memory profile of a DDlog program. | |||
There was a problem hiding this comment.
Isn't there some overhead for adding all this code, even if profiling is disabled?
There was a problem hiding this comment.
Should be negligible. The runtime callback is invoked once for every batch and basically just updates two keys in two different maps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/frankmcsherry/differential-dataflow/issues/113 and https://github.com/frankmcsherry/differential-dataflow/issues/114