-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove pkg/generated #7627
fix: remove pkg/generated #7627
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7627 +/- ##
=======================================
Coverage 58.80% 58.80%
=======================================
Files 345 345
Lines 28759 28759
=======================================
Hits 16911 16911
Misses 10420 10420
Partials 1428 1428 ☔ View full report in Codecov by Sentry. |
As @sseago commented with me "regarding removing pkg/generated, that was only deprecated in 1.13, so probably shouldn't remove it until 1.15 at the earliest" I am drafting this PR until it is time, but it should be good enough already, only codecov job failed... |
The CI job failed with the codecov result uploading. |
32ac556
to
c089437
Compare
Per discussion this will be merged post-v1.14 |
c089437
to
5b25f86
Compare
We can start to work on this PR because the release-1.14 branch was already cut. |
Signed-off-by: Mateus Oliveira <[email protected]>
Signed-off-by: Mateus Oliveira <[email protected]>
Signed-off-by: Mateus Oliveira <[email protected]>
5b25f86
to
1c950f6
Compare
undrafted the PR |
dcoapp/app#211 (comment) |
Signed-off-by: Mateus Oliveira <[email protected]>
done |
Please add a summary of your change
Deleted
pkg/generated/
folder.Does your change fix a particular issue?
Fixes #6190
Fixes openshift/oadp-operator#1221
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.