Add functional options for the Ark config install library #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
reviewed
May 18, 2018
pkg/install/config.go
Outdated
| } | ||
| } | ||
|
|
||
| func WithScheduleSyncPeriod(t time.Duration) arkConfigOption { |
There was a problem hiding this comment.
We're planning on removing this configuration option and instead hardcoding it to 1 minute, so we may want to omit this.
There was a problem hiding this comment.
OK, i'll remove the option for now and leave the resource specification hardcoded to 1 minute.
ncdc
reviewed
May 22, 2018
pkg/install/config.go
Outdated
| type arkConfig struct { | ||
| backupSyncPeriod time.Duration | ||
| gcSyncPeriod time.Duration | ||
| scheduleSyncPeriod time.Duration |
Signed-off-by: Mike Arpaia <[email protected]>
skriss
approved these changes
May 22, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #437, we decided we wanted to use functional options to manage Ark config details (instead of defaulting to static times). This PR adds such a capability.