Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image builds of master are failing #833

Closed
skriss opened this issue Sep 10, 2018 · 1 comment · Fixed by #835
Closed

image builds of master are failing #833

skriss opened this issue Sep 10, 2018 · 1 comment · Fixed by #835
Assignees
Labels

Comments

@skriss
Copy link
Contributor

skriss commented Sep 10, 2018

The changes from #795 are causing image builds of master to fail. I haven't had a chance to look at why, but I think it's probably an easy fix. I'll get to it later today or tomorrow if someone else doesn't take it first.

cc @carlisia @nrb @wwitzel3

@nrb
Copy link
Contributor

nrb commented Sep 10, 2018

I'll start looking

nrb pushed a commit to nrb/velero that referenced this issue Sep 10, 2018
Due to the version of docker used to build images, the Dockerfile used
with -f must be in the same directory that's used for the context. Copy
the Dockerfile into the _output directory and make the custom targets
more closely match the standard ones.

Fixes vmware-tanzu#833

Signed-off-by: Nolan Brubaker <[email protected]>
nrb pushed a commit to nrb/velero that referenced this issue Sep 11, 2018
Due to the version of docker used to build images, the Dockerfile used
with -f must be in the same directory that's used for the context. Copy
the Dockerfile into the _output directory and make the custom targets
more closely match the standard ones.

Fixes vmware-tanzu#833

Signed-off-by: Nolan Brubaker <[email protected]>
nrb pushed a commit to nrb/velero that referenced this issue Sep 12, 2018
Due to the version of docker used to build images, the Dockerfile used
with -f must be in the same directory that's used for the context. Copy
the Dockerfile into the _output directory and make the custom targets
more closely match the standard ones.

Fixes vmware-tanzu#833

Signed-off-by: Nolan Brubaker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants