Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If we allow the pod->pvc->pv flow to be disabled, try to find a way to run pre/post snapshot hooks #591

Closed
ncdc opened this issue Jun 25, 2018 · 1 comment
Labels
Candidate for close Issues that should be closed and need a team review before closing Enhancement/User End-User Enhancement to Velero
Milestone

Comments

@ncdc
Copy link
Contributor

ncdc commented Jun 25, 2018

If we allow plugins to be disabled (#584), then we'll want to try to find a way to allow the user to run pre/post snapshot hooks. The current mechanism is:

  1. Ark starts to process a pod and invokes the pre hook
  2. Ark sees the pod has a PVC, so it processes the PVC immediately
  3. Ark processes the PVC and finds its associated PV, so it processes the PV immediately
  4. Ark process the PV and creates the snapshot
  5. Ark invokes the post hook for the pod
  6. Ark writes the pod json to the backup tarball

If we don't have this, we'll need some way to coordinate pre/post hooks at the pod level while somehow making sure we snapshot in the middle of the process.

cc @SleepyBrett

@ncdc ncdc added the Enhancement/User End-User Enhancement to Velero label Jun 25, 2018
@ncdc ncdc added this to the v1.0.0 milestone Jun 25, 2018
@ncdc ncdc modified the milestones: v1.0.0, TBD Nov 27, 2018
@skriss skriss added the Candidate for close Issues that should be closed and need a team review before closing label Sep 10, 2019
@skriss
Copy link
Contributor

skriss commented Sep 19, 2019

Thanks for this request. We are not currently prioritizing this item within our roadmap, and as such will be closing out the issue. Please feel free to reach out as needed in this issue or a new one.

@skriss skriss closed this as completed Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Candidate for close Issues that should be closed and need a team review before closing Enhancement/User End-User Enhancement to Velero
Projects
None yet
Development

No branches or pull requests

2 participants