Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define how to enable/disable and configure plugins #584

Open
ncdc opened this issue Jun 25, 2018 · 2 comments
Open

Define how to enable/disable and configure plugins #584

ncdc opened this issue Jun 25, 2018 · 2 comments
Labels
Area/Plugins Issues related to plugin infra/internal plugins Breaking change Impacts backwards compatibility Enhancement/User End-User Enhancement to Velero Icebox We see the value, but it is not slated for the next couple releases. kind/requirement Reviewed Q2 2021

Comments

@ncdc
Copy link
Contributor

ncdc commented Jun 25, 2018

For example, some users might not want to enable the plugins that automatically walk from pod to pvc to pv.

@ncdc ncdc added P1 - Important Enhancement/User End-User Enhancement to Velero labels Jun 25, 2018
@ncdc ncdc added this to the v1.0.0 milestone Jun 25, 2018
@ncdc ncdc added the Breaking change Impacts backwards compatibility label Jun 27, 2018
@ncdc ncdc modified the milestones: v1.0.0, v0.12.0 Nov 28, 2018
@ncdc
Copy link
Contributor Author

ncdc commented Nov 29, 2018

Let's say we want to enable/disable and configure the "foo.com/pod" BackupItemAction. Possible options:

  • Create a ConfigMap in the heptio-ark namespace, the name can be whatever:
apiVersion: v1
kind: ConfigMap
metadata:
  name: foo-com-pod-config
  labels:
    ark.heptio.com/plugin-config: foo.com/pod
data:
  enabled: false
  addAnnotations:
    color: green
    size: small

Let's say we just want to disable a plugin that has no configuration:

  • add --enable-plugins NAME(s) and/or --disable-plugins NAME(s) flags to the ark server
  • use ConfigMaps and Ark is responsible for checking for an enable/disable annotation:
apiVersion: v1
kind: ConfigMap
metadata:
  name: foo-com-pod-config
  labels:
    ark.heptio.com/plugin-config: foo.com/pod
    ark.heptio.com/plugin-enabled: false

Proposed approach:

  1. Admin uses --enable-plugins and/or --disable-plugins flag for the ark server to control which plugins are enabled
  2. Admin and/or users can create ConfigMaps to configure their plugins, assuming plugins support configuration

@skriss skriss modified the milestones: v0.12.0, v1.0.0 Apr 3, 2019
@skriss skriss added the Area/Plugins Issues related to plugin infra/internal plugins label May 13, 2019
@carlisia carlisia self-assigned this May 15, 2019
@skriss skriss modified the milestones: v1.0.0, v1.x May 20, 2019
@carlisia carlisia removed their assignment Dec 13, 2019
@carlisia
Copy link
Contributor

Un-assigned myself since I'm not currently working on this.

@nrb nrb removed this from the v1.x milestone Dec 8, 2020
@eleanor-millman eleanor-millman added the Icebox We see the value, but it is not slated for the next couple releases. label May 3, 2021
@reasonerjt reasonerjt removed Breaking change Impacts backwards compatibility Enhancement/User End-User Enhancement to Velero Area/Plugins Issues related to plugin infra/internal plugins Reviewed Q2 2021 Icebox We see the value, but it is not slated for the next couple releases. labels May 20, 2022
@reasonerjt reasonerjt added kind/requirement Icebox We see the value, but it is not slated for the next couple releases. Reviewed Q2 2021 Area/Plugins Issues related to plugin infra/internal plugins Enhancement/User End-User Enhancement to Velero Breaking change Impacts backwards compatibility labels May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Plugins Issues related to plugin infra/internal plugins Breaking change Impacts backwards compatibility Enhancement/User End-User Enhancement to Velero Icebox We see the value, but it is not slated for the next couple releases. kind/requirement Reviewed Q2 2021
Projects
None yet
Development

No branches or pull requests

7 participants