Add additional generic components and helpers #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anujc25
commented
Jan 21, 2025
|
|
||
| type commandKey struct{} | ||
|
|
||
| func WithCommand(ctx context.Context, cmd *cobra.Command) context.Context { |
There was a problem hiding this comment.
Should we rename this to WithContext? So, invocation will be command.WithContext(ctx, cmd) ?
anujc25
commented
Jan 21, 2025
| return context.WithValue(ctx, commandKey{}, cmd) | ||
| } | ||
|
|
||
| func CommandFromContext(ctx context.Context) *cobra.Command { |
There was a problem hiding this comment.
Should we rename this to FromContext? So, invocation will be command.FromContext(ctx) ?
anujc25
force-pushed
the
add-plugin-helper
branch
from
9314b92 to
81995d3
Compare
anujc25
force-pushed
the
add-plugin-helper
branch
from
81995d3 to
5a47482
Compare
anujc25
commented
Jan 23, 2025
Comment on lines
+12
to
+15
| const ( | ||
| NameArgumentName = "name" | ||
| NamesArgumentName = "name(s)" | ||
| ) |
There was a problem hiding this comment.
Are these generic enough to be kept here? Also applies to NameArg, OptionalNameArg, NamesArg functions below.
anujc25
commented
Feb 1, 2025
Comment on lines
+13
to
+20
| var ( | ||
| FaintColor = color.New(color.Faint) | ||
| InfoColor = color.New(color.FgCyan) | ||
| SuccessColor = color.New(color.FgGreen) | ||
| WarnColor = color.New(color.FgYellow) | ||
| ErrorColor = color.New(color.FgRed) | ||
| BoldColor = color.New(color.Bold) | ||
| ) |
There was a problem hiding this comment.
Noticed that we already have compnent/colorable-tty.go which holds similar color specific helpers. Check to see how we can combine both.
anujc25
commented
Feb 3, 2025
There was a problem hiding this comment.
Any suggestion on the package name characters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add additional generic components and helpers functions
Arg,ErrorandExtendhelpers undercommandpackagecomponent/characterspackagecomponent/printerpackagecomponent/tabwriterpackageWhich issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer