documentation update #978
Merged
documentation update #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Volkan Ozcelik <[email protected]>
Signed-off-by: Volkan Ozcelik <[email protected]>
v0lkan
commented
Jun 3, 2024
| return strings.HasPrefix(spiffeid, env.SpiffeIdPrefixForSentinel()) | ||
| prefix := env.SpiffeIdPrefixForSentinel() | ||
|
|
||
| if strings.HasPrefix(prefix, spiffeRegexPrefixStart) { |
There was a problem hiding this comment.
If the env var starts with a ^, then we do a regular expression match.
We intentionally use ^ because we would at least want to match the trust domain in the regular expression for security and to avoid configuration errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR updates documentation and release notes.
I also added some code that has been overwritten while rebasing the code.