Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ test(VSecM): increase test coverage from core/env #970

Merged
merged 1 commit into from
May 26, 2024
Merged

✨ test(VSecM): increase test coverage from core/env #970

merged 1 commit into from
May 26, 2024

Conversation

muratmirgun
Copy link
Contributor

@muratmirgun muratmirgun commented May 26, 2024

Increase test coverage from core/env and fix test-coverage makefile

Description

Test coverage up to %15.2 from %13.2

Changes

Test Policy Compliance

  • I have added or updated unit tests for my changes.
  • I have included integration tests where applicable.
  • All new and existing tests pass successfully.

Code Quality

  • I have followed the coding standards for this project.
  • I have performed a self-review of my code.
  • My code is well-commented, particularly in areas that may be difficult
    to understand.

Documentation

  • I have made corresponding changes to the documentation (if applicable).
  • I have updated any relevant READMEs or wiki pages.

Additional Comments

Include any additional comments or context about the PR here.

Checklist

Before you submit this PR, please make sure:

  • You have read the contributing guidelines and
    especially the test policy.
  • You have thoroughly tested your changes.
  • You have followed all the contributing guidelines for this project.
  • You understand and agree that your contributions will be publicly available
    under the project's license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project's license and that you have the authority to grant
these rights.


Thank you for your contribution to VMware Secrets Manager
🐢⚡️!

@muratmirgun muratmirgun requested a review from BulldromeQ as a code owner May 26, 2024 21:22
Copy link
Contributor

@v0lkan v0lkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Thanks for your contribution 🙏 .

Merging this… I’ll test it on the integration server sometime next week.

@v0lkan v0lkan merged commit 9bfc19f into vmware-tanzu:main May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants