Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌟 enhancement(VSecM Helm Charts): Add kapp annotations and pull secrets #1152

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

v0lkan
Copy link
Contributor

@v0lkan v0lkan commented Oct 1, 2024

Add Optional kApp Annotations and Missing Pull Secrets to the Helm Charts

Description

This PR adds certain annotations and attributes to the VSecM and SPIRE helm charts.

Changes

List the major changes you have made in bullet points:

  • Added kApp annotations for those who might be using Carvel tool.
  • Also added a few missing imagePullSecrets that might have caused trouble for airgapped deployments.

Test Policy Compliance

  • I have added or updated unit tests for my changes.
  • I have included integration tests where applicable.
  • All new and existing tests pass successfully.

Code Quality

  • I have followed the coding standards for this project.
  • I have performed a self-review of my code.
  • My code is well-commented, particularly in areas that may be difficult
    to understand.

Documentation

  • I have made corresponding changes to the documentation (if applicable).
  • I have updated any relevant READMEs or wiki pages.

Checklist

Before you submit this PR, please make sure:

  • You have read the contributing guidelines and
    especially the test policy.
  • You have thoroughly tested your changes.
  • You have followed all the contributing guidelines for this project.
  • You understand and agree that your contributions will be publicly available
    under the project's license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project's license and that you have the authority to grant
these rights.


Thank you for your contribution to VMware Secrets Manager
🐢⚡️!

Added kApp annotations for those who might be using Carvel tool.

Also added a few missing imagePullSecrets that might have caused trouble
for airgapped deployments.

Signed-off-by: Volkan Özçelik <[email protected]>
@v0lkan v0lkan self-assigned this Oct 1, 2024
@v0lkan v0lkan requested a review from BulldromeQ as a code owner October 1, 2024 20:41
@v0lkan v0lkan merged commit 4235abe into main Oct 2, 2024
@v0lkan v0lkan deleted the ovolkan/helm branch October 2, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant