Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: fix potential panic & refactor some code #1123

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

canack
Copy link
Contributor

@canack canack commented Aug 27, 2024

Hi, I've made few changes, I hope it makes secrets-manager better 🧪

@canack canack requested a review from BulldromeQ as a code owner August 27, 2024 20:38
@vmwclabot
Copy link

@canack, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@v0lkan
Copy link
Contributor

v0lkan commented Aug 27, 2024

Thanks for your contributions @canack

Can you also sign-off your commits for us to be able to merge them in.

Best.

canack added 6 commits August 28, 2024 00:11
Signed-off-by: Engin Acikgoz <[email protected]>
Signed-off-by: Engin Acikgoz <[email protected]>
Signed-off-by: Engin Acikgoz <[email protected]>
Signed-off-by: Engin Acikgoz <[email protected]>
This reverts commit d0b1eaf.
Signed-off-by: Engin Acikgoz <[email protected]>
@canack canack requested a review from v0lkan August 27, 2024 21:15
@v0lkan v0lkan merged commit 7f9a241 into vmware-tanzu:main Aug 27, 2024
@v0lkan
Copy link
Contributor

v0lkan commented Aug 27, 2024

Landed.

Thanks for your contributions @canack .

@canack canack deleted the improve branch September 13, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants