-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: fix potential panic & refactor some code #1123
Conversation
@canack, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Thanks for your contributions @canack Can you also sign-off your commits for us to be able to merge them in. Best. |
Signed-off-by: Engin Acikgoz <[email protected]>
Signed-off-by: Engin Acikgoz <[email protected]>
Signed-off-by: Engin Acikgoz <[email protected]>
Signed-off-by: Engin Acikgoz <[email protected]>
Signed-off-by: Engin Acikgoz <[email protected]>
This reverts commit d0b1eaf. Signed-off-by: Engin Acikgoz <[email protected]>
Landed. Thanks for your contributions @canack . |
Hi, I've made few changes, I hope it makes secrets-manager better 🧪